From: Nikita Pettik <korablev@tarantool.org>
To: Maxim Kulis <bokuno@picodata.io>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] vinyl: prohibit vinyl_level_size_ratio less than two
Date: Fri, 31 Jan 2020 03:24:11 +0300 [thread overview]
Message-ID: <20200131002411.GA62548@tarantool.org> (raw)
In-Reply-To: <1579863862.443401751@f420.i.mail.ru>
On 24 Jan 14:04, Maxim Kulis wrote:
>
>
> Hi!
> Yes, here is the new patch.
>
> Change the minimum possible value of the variable vinyl_run_size_ratio to 2.
>
> Closes #3346
>
> issue: https://github.com/tarantool/tarantool/issues/3346
> ---
Put a link to the issue below '---' delimiter next time.
> >> >Finally, I would add brief explanation to the commit message why
> >> >run_size_ratio less than 2 is meaningless (for those who are not
> >> >familiar with vinyl inner organization).
Please, add a brief explanation to the commit message and then patch will
be OK to push. Thanks.
next prev parent reply other threads:[~2020-01-31 0:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 16:11 Maksim Kulis
2019-12-05 11:27 ` Nikita Pettik
[not found] ` <1578908907.647593657@f120.i.mail.ru>
2020-01-15 17:36 ` Nikita Pettik
2020-01-24 11:04 ` Maxim Kulis
2020-01-31 0:24 ` Nikita Pettik [this message]
2020-02-04 0:27 ` Maxim Kulis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131002411.GA62548@tarantool.org \
--to=korablev@tarantool.org \
--cc=bokuno@picodata.io \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] vinyl: prohibit vinyl_level_size_ratio less than two' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox