Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] small: unite the oscillation cache of all mempools
Date: Thu, 30 Jan 2020 17:47:51 +0300	[thread overview]
Message-ID: <20200130144751.GA12727@atlas> (raw)
In-Reply-To: <20200130130558.oimnahjmnecmvcpt@tkn_work_nb>

* Alexander Turenko <alexander.turenko@tarantool.org> [20/01/30 17:38]:
> The processes were not better (at least) when you was manager here. Now
> you don't seat near us and have even less necessary context. Yep, I
> personally think that we should ignore your suggestions in this area.
> This is not a viewpoint of the company, it is my personal opinion.

This logic is flawed. If something was wrong before, no reason to
keep going like that now. 

> 
> And since DDL tests are entirely unrelated to this thread, it does not
> look as feedback, whose goal is to suggest us to raise priority of this
> issue. It is either emotions or attempt to present us is an unfavourable
> light (because of, again, emotions or business needs of your tarantool
> consulting, but likely the former).
> 
> Sorry if it looks offending.

It's not about "business" or "emotions" at all. I have been
suggesting before, that decisions like that should be taken by
maintainers, not managers.

This is a governance issue, and it is in the interest of everyone
if it is solved. Right now whatever decision
Kirill may take is by definition subjective, especially since
there is no public policy and the expertise in Mail.Ru is scarce.

> (I propose to don't continue this particular discussion, at least here.)

Well, I definitely don't want to discuss emotions. But I have been
repeatedly saying there should be a policy open to external
contributions that serves in the best interest of the project.

> > As I said, I don't think this tiny patch justifies it. 
> > The patch fixes a real issue that multiple users have hit.
> 
> This is one example of the bad processes that we had when you did work
> with us: 'Kostja said LGTM, so proper testing is not necessary'.

Not necessarily. You could make an internal review, like you do
with other patches that I LGTM.

> > If bench.tarantool.org was operational, it would be easy to see if
> > the patch has any impact on performance. This is the only remotely
> > relevant concern here.
> 
> Maybe. Black box testing is not always enough.
> 
> > 
> > Meanwhile, if you wish to ignore it because it doesn't come with a
> > testing infrastructure - it's up to you.
> 
> I had asked for a workload that can show gains under manual run at
> least. Not a testing infrastructure.

Obviously that wasn't clear. Such a workload is easy to build.

-- 
Konstantin Osipov, Moscow, Russia

  reply	other threads:[~2020-01-30 14:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29  1:48 Maksim Kulis
2020-01-29 10:28 ` Kirill Yukhin
2020-01-29 21:46   ` Konstantin Osipov
2020-01-30  8:02     ` Kirill Yukhin
2020-01-30  8:34       ` Konstantin Osipov
2020-01-30 11:18         ` Alexander Turenko
2020-01-30 12:23           ` Konstantin Osipov
2020-01-30 13:05             ` Alexander Turenko
2020-01-30 14:47               ` Konstantin Osipov [this message]
2020-01-30 12:20         ` Kirill Yukhin
2020-01-30 12:36           ` Konstantin Osipov
2020-04-10  8:36 Aleksandr Lyapunov
     [not found] ` <CAPZPwLrNbdCzX7LR+_P8xrZ+unDpw-k2EP1Jj5mAsGOTWz2frA@mail.gmail.com>
2020-04-10 12:44   ` Aleksandr Lyapunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200130144751.GA12727@atlas \
    --to=kostja.osipov@gmail.com \
    --cc=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] small: unite the oscillation cache of all mempools' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox