Re: [Tarantool-patches] [PATCH] small: unite the oscillation cache of all mempools

[Konstantin Osipov <kostja.osipov@gmail.com>]

* Alexander Turenko <alexander.turenko@tarantool.org> [20/01/30 14:21]:
> This mailing lists is not about your (or somebody else) emotions around
> tarantool. Please, keep them private or send to some other place.

Is it OK to laugh, or you're going to ban for a joke?

And anyway, it was not about emotions. I've given you
feedback about the quality of the process - you can try to
address it or dismiss, like you've just did, and like you did
a few times before, it's of course up to you.

> > PS It is of course possible to show that memory fragmentation has
> > decreased with this patch by allocating a few objects and looking
> > at memory stats. But such test will be fragile and thus bring more
> > harm than good. 
> 
> You may LD_PRELOAD your own mmap() / munmap() / malloc() / free() (see
> [1]) and count number of calls. This way you can look at the behaviour
> before and after the patch manually or (maybe) automatically.
> 
> Just strace may be okay too, but there should be a case, which will show
> that amount of mmap/munmap/malloc/free syscalls is decreased.
> 
> [1]: https://tbrindus.ca/correct-ld-preload-hooking-libc/

As I said, I don't think this tiny patch justifies it. 
The patch fixes a real issue that multiple users have hit.

If bench.tarantool.org was operational, it would be easy to see if
the patch has any impact on performance. This is the only remotely
relevant concern here.

Meanwhile, if you wish to ignore it because it doesn't come with a
testing infrastructure - it's up to you.



it's worth it, neither for this patch 

-- 
Konstantin Osipov, Moscow, Russia