From: Kirill Yukhin <kyukhin@tarantool.org>
To: Maksim Kulis <bokuno@picodata.io>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] small: unite the oscillation cache of all mempools
Date: Wed, 29 Jan 2020 13:28:13 +0300 [thread overview]
Message-ID: <20200129102813.3gsdeo27lmoh2zsi@tarantool.org> (raw)
In-Reply-To: <20200129014816.14248-1-bokuno@picodata.io>
Hello,
On 29 янв 04:48, Maksim Kulis wrote:
> The task is to unite the oscillation cache of all mempools.
> In the function slab_put_with_order() we check if there is any
> slab of the largest size except the current one, in order to
> avoid oscillation.
> https://github.com/tarantool/small/blob/master/small/slab_cache.c#L349
Thanks a lot for your patch. Since the change is performance
related, before we start off review process, please provide a
testcase (for tarantool or whatever) which will clearly show
that there're cases where performance is actually increased.
We won't accept "nice looking" perf patches.
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2020-01-29 10:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 1:48 Maksim Kulis
2020-01-29 10:28 ` Kirill Yukhin [this message]
2020-01-29 21:46 ` Konstantin Osipov
2020-01-30 8:02 ` Kirill Yukhin
2020-01-30 8:34 ` Konstantin Osipov
2020-01-30 11:18 ` Alexander Turenko
2020-01-30 12:23 ` Konstantin Osipov
2020-01-30 13:05 ` Alexander Turenko
2020-01-30 14:47 ` Konstantin Osipov
2020-01-30 12:20 ` Kirill Yukhin
2020-01-30 12:36 ` Konstantin Osipov
2020-04-10 8:36 Aleksandr Lyapunov
[not found] ` <CAPZPwLrNbdCzX7LR+_P8xrZ+unDpw-k2EP1Jj5mAsGOTWz2frA@mail.gmail.com>
2020-04-10 12:44 ` Aleksandr Lyapunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129102813.3gsdeo27lmoh2zsi@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=bokuno@picodata.io \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] small: unite the oscillation cache of all mempools' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox