Re: [Tarantool-patches] [PATCH] Increase limits for debug.traceback

[Igor Munkin <imun@tarantool.org>]

Sergey,

Thanks, LGTM.

On 22.01.20, Sergey Voinov wrote:
> Currently debug.traceback cuts out path prefixes
> and removes intermediate frames. This makes it harder
> to debug and navigate to files right from terminal.
> 
> This change in main trunk adds default traceback
> limits as defines to cmake/luajit.cmake file.
> 
> Please see the commit for #4581 for luajit submodule.
> 
> Closes: #4581
> ---
>  issue: https://github.com/tarantool/tarantool/issues/4581
>  branch: https://github.com/tarantool/tarantool/tree/servoin/gh-4581-debug-limits_2
>  cmake/luajit.cmake | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/cmake/luajit.cmake b/cmake/luajit.cmake
> index 072db8269..373e88458 100644
> --- a/cmake/luajit.cmake
> +++ b/cmake/luajit.cmake
> @@ -282,6 +282,13 @@ macro(luajit_build)
>          DESTINATION ${MODULE_INCLUDEDIR})
>  endmacro()
>  
> +#
> +# Definitions for luajit debug traceback limits
> +#
> +add_definitions(-DLUA_TRACEBACK_LEVELS1=25)
> +add_definitions(-DLUA_TRACEBACK_LEVELS2=25)
> +add_definitions(-DLUA_IDSIZE=128)
> +
>  #
>  # Building shipped luajit only if there is no
>  # usable system one (see cmake/luajit.cmake) or by demand.
> -- 
> 2.17.1
> 

-- 
Best regards,
IM