From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 2/2] memtx: increase the memory quota if needed to truncate or delete
Date: Fri, 24 Jan 2020 14:21:34 +0300 [thread overview]
Message-ID: <20200124112134.GA8586@atlas> (raw)
In-Reply-To: <37bd8a76-11b5-e560-8bf8-acaa2539eaaf@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [20/01/15 00:03]:
> Thanks for the patch!
>
> JFI, I am still against this patch. It adds huge and
> unnecessary complexity to the code, which we will need
> to support forever. It is just not worth the pros the
> patch gives.
I don't get why insertion of truncation tuple can not use the
same reserved memory segments which are used for RTREE recovery.
We can just one +1 blog to the reserved list to accommodate for
truncate.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-01-24 11:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 21:31 [Tarantool-patches] [PATCH v2 0/2] Safe truncation and deletion Ilya Kosarev
2020-01-13 21:31 ` [Tarantool-patches] [PATCH v2 1/2] b-tree: return NULL on matras_alloc fail Ilya Kosarev
2020-01-14 21:00 ` Vladislav Shpilevoy
2020-01-20 18:13 ` Ilya Kosarev
2020-01-13 21:31 ` [Tarantool-patches] [PATCH v2 2/2] memtx: increase the memory quota if needed to truncate or delete Ilya Kosarev
2020-01-14 21:00 ` Vladislav Shpilevoy
2020-01-20 18:13 ` Ilya Kosarev
2020-01-24 11:21 ` Konstantin Osipov [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-10 0:36 [Tarantool-patches] [PATCH v2 0/2] Safe truncation and deletion Ilya Kosarev
2020-01-10 0:36 ` [Tarantool-patches] [PATCH v2 2/2] memtx: increase the memory quota if needed to truncate or delete Ilya Kosarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124112134.GA8586@atlas \
--to=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 2/2] memtx: increase the memory quota if needed to truncate or delete' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox