From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH decNumber 1/1] Fix build on Mac with gcc and XCode 11
Date: Fri, 24 Jan 2020 05:19:30 +0300 [thread overview]
Message-ID: <20200124021930.ooxclznzptcbyl5j@tkn_work_nb> (raw)
In-Reply-To: <20191210141305.yu5nhjqztso5dcfb@tarantool.org>
On Tue, Dec 10, 2019 at 05:13:05PM +0300, Kirill Yukhin wrote:
> Hello,
>
> On 01 дек 22:01, Vladislav Shpilevoy wrote:
> > There is a bug in XCode 11 which makes some standard C headers
> > not self sufficient. At least <stdlib.h> and <algorithm> are
> > affected. When they are included first, compilation fails with
> > creepy errors like this:
> >
> > In file included
> > from /Applications/Xcode.app/Contents/Developer/
> > Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/
> > sys/wait.h:110,
> > from /Applications/Xcode.app/Contents/Developer/
> > Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/
> > stdlib.h:66,
> > from /Users/gerold/Work/Repositories/tarantool/third_party/
> > zstd/lib/common/zstd_common.c:16:
> > /Applications/Xcode.app/Content/Developer/
> > Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/
> > sys/resource.h:
> > In function 'getiopolicy_np': /Applications/Xcode.app/Contents/Developer/
> > Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/
> > sys/resource.h:447:34: error:
> > expected declaration specifiers before '__OSX_AVAILABLE_STARTING'
> > 447 | int getiopolicy_np(int, int)
> > __OSX_AVAILABLE_STARTING(__MAC_10_5, __IPHONE_2_0);
> >
> > The patch workarounds the bug by changing header include order.
> > Part of https://github.com/tarantool/tarantool/issues/4580
>
> Checked into master and bumped new version in Tarantool.
Are there a reason to don't push the bugfix to 2.2?
It will prevent clean applying of future updates of the submodule, so I
would prefer to update it everywhere.
WBR, Alexander Turenko.
prev parent reply other threads:[~2020-01-24 2:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-01 21:01 Vladislav Shpilevoy
2019-12-10 14:13 ` Kirill Yukhin
2020-01-24 2:19 ` Alexander Turenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124021930.ooxclznzptcbyl5j@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH decNumber 1/1] Fix build on Mac with gcc and XCode 11' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox