From: Igor Munkin <imun@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] add memory leaks detection via LSAN
Date: Tue, 21 Jan 2020 17:25:39 +0300 [thread overview]
Message-ID: <20200121142539.GF26983@tarantool.org> (raw)
In-Reply-To: <cover.1579509793.git.avtikhon@tarantool.org>
Sasha Ti.,
Thanks, LGTM.
### NB:
AFAICS, there are also two more branches related to the issue: one for
1.10[1] and one for 2.2[2]. Please consider the following actions:
* Explicitly specify the target branches for the current patchset
* Adjust the braches for 1.10 and 2.2 regarding the comments I left for
the first version of the series
Sasha Tu. please proceed with the patchset.
On 20.01.20, Alexander V. Tikhonov wrote:
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-2058-asan-with-leaks
> Issue: https://github.com/tarantool/tarantool/issues/2058
>
> v1: https://lists.tarantool.org/pipermail/tarantool-patches/2020-January/013682.html
>
> Changes v2:
> - made suggested corrections
>
> Changes v1:
> - initial version
>
> Alexander V. Tikhonov (2):
> test: use default replication connection timeout
> gitlab-ci: add memory leaks detection via LSAN
>
> .travis.mk | 17 ++-
> asan/asan.supp | 17 +++
> asan/lsan.supp | 105 ++++++++++++++++++
> cmake/profile.cmake | 4 +-
> test/box/on_shutdown.skipcond | 7 ++
> test/replication/autobootstrap.lua | 2 -
> test/replication/autobootstrap.result | 2 +-
> test/replication/autobootstrap.test.lua | 2 +-
> test/replication/autobootstrap_guest.lua | 2 -
> test/replication/before_replace.result | 6 +-
> test/replication/before_replace.test.lua | 6 +-
> test/replication/ddl.lua | 2 -
> test/replication/hot_standby.lua | 1 -
> test/replication/master.lua | 1 -
> test/replication/master_quorum.lua | 2 -
> test/replication/on_replace.lua | 2 -
> test/replication/quorum.lua | 2 -
> test/replication/quorum.result | 15 ++-
> test/replication/quorum.test.lua | 15 ++-
> test/replication/rebootstrap.lua | 2 -
> test/replication/rebootstrap.result | 4 +-
> test/replication/rebootstrap.test.lua | 4 +-
> test/replication/recover_missing_xlog.result | 2 +-
> .../replication/recover_missing_xlog.test.lua | 2 +-
> test/replication/replica.lua | 1 -
> test/replication/replica_auth.lua | 2 -
> test/replication/replica_no_quorum.lua | 1 -
> test/replication/replica_quorum.lua | 2 -
> test/replication/replica_timeout.lua | 2 -
> test/replication/replica_uuid.lua | 1 -
> test/replication/replica_uuid_ro.lua | 2 -
> test/replication/replicaset_ro_mostly.result | 2 +-
> .../replication/replicaset_ro_mostly.test.lua | 2 +-
> test/replication/wal_off.lua | 1 -
> 34 files changed, 172 insertions(+), 68 deletions(-)
> create mode 100644 asan/asan.supp
> create mode 100644 asan/lsan.supp
> create mode 100644 test/box/on_shutdown.skipcond
>
> --
> 2.17.1
>
[1]: https://github.com/tarantool/tarantool/tree/avtikhon/gh-2058-asan-with-leaks_1.10
[2]: https://github.com/tarantool/tarantool/tree/avtikhon/gh-2058-asan-with-leaks_2.2
--
Best regards,
IM
prev parent reply other threads:[~2020-01-21 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 10:50 Alexander V. Tikhonov
2020-01-20 10:50 ` [Tarantool-patches] [PATCH v2 1/2] test: use default replication connection timeout Alexander V. Tikhonov
2020-03-27 14:07 ` Sergey Bronnikov
2020-01-20 10:50 ` [Tarantool-patches] [PATCH v2 2/2] gitlab-ci: add memory leaks detection via LSAN Alexander V. Tikhonov
2020-03-27 14:06 ` Sergey Bronnikov
2020-03-30 7:53 ` Alexander Tikhonov
2020-03-30 8:09 ` Sergey Bronnikov
2020-04-01 11:04 ` Alexander Tikhonov
2020-01-21 14:25 ` Igor Munkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121142539.GF26983@tarantool.org \
--to=imun@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/2] add memory leaks detection via LSAN' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox