Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/2] box/applier: add missing diag_set on region_alloc failure
Date: Mon, 20 Jan 2020 13:59:10 +0300	[thread overview]
Message-ID: <20200120105910.GD2437@uranus> (raw)
In-Reply-To: <20200120083148.GC19835@atlas>

On Mon, Jan 20, 2020 at 11:31:48AM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov@gmail.com> [20/01/17 16:32]:
> > In case if we're hitting memory limit allocting triggers
> > we should setup diag error to prevent nil dereference
> > in diag_raise call for example from applier_apply_tx.
> 
> It used to be region_alloc_xc, which would throw exception.
> 
> So it's a regression introduced by some of the "cleanup" patches.
> 
> Could you please find when it was introduced?

According to git logs region_alloc_xc has never been used here,
it indroduced by 8c84932ade1b70971890dfd27d72b3145834594b

      parent reply	other threads:[~2020-01-20 10:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-17 13:29 [Tarantool-patches] [PATCH 0/2] origin/2.2: add missing diag_set calls on error paths Cyrill Gorcunov
2020-01-17 13:29 ` [Tarantool-patches] [PATCH 1/2] box/request: add missing OutOfMemory diag_set Cyrill Gorcunov
2020-01-17 13:29 ` [Tarantool-patches] [PATCH 2/2] box/applier: add missing diag_set on region_alloc failure Cyrill Gorcunov
2020-01-20  8:31   ` Konstantin Osipov
2020-01-20  8:44     ` Cyrill Gorcunov
2020-01-20 10:59     ` Cyrill Gorcunov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200120105910.GD2437@uranus \
    --to=gorcunov@gmail.com \
    --cc=kostja.osipov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 2/2] box/applier: add missing diag_set on region_alloc failure' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox