From: Nikita Pettik <korablev@tarantool.org>
To: Chris Sosnin <k.sosnin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] sql: allow accessing list of collations via pragma
Date: Fri, 17 Jan 2020 22:15:28 +0300 [thread overview]
Message-ID: <20200117191528.GD82780@tarantool.org> (raw)
In-Reply-To: <20200116084125.28506-1-k.sosnin@tarantool.org>
On 16 Jan 11:41, Chris Sosnin wrote:
> Hi! Thank you for the review!
>
> > Content returned by 'pragma collation_list' is already verified in
> > sql-tap/collation.test.lua. So I guess it is enough to check that
> > box.execute("pragma collation_list") does not throw an error.
>
> I'm sorry, didn't notice such test exists. I changed the patch so it only
> checks for an error:
> +-- gh-4713 "PRAGMA collation_list" is not accessible to all users
> +_, err = box.execute('pragma collation_list')
> +assert(err == nil)
>
> See the whole patch below.
>
> 'pragma collation_list' uses _collation space, although user
> may have no access to it. Thus, we replace it with the
> corresponding view.
>
> Closes #4713
> ---
> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4713-pragma-collation-list
> issue: https://github.com/tarantool/tarantool/issues/4713
Pushed to master, 2.2 and 2.3 branches. Thanks.
prev parent reply other threads:[~2020-01-17 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 7:52 Chris Sosnin
2020-01-15 16:56 ` Nikita Pettik
2020-01-16 8:41 ` Chris Sosnin
2020-01-17 19:15 ` Nikita Pettik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117191528.GD82780@tarantool.org \
--to=korablev@tarantool.org \
--cc=k.sosnin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] sql: allow accessing list of collations via pragma' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox