From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 3/3] box: remove dead code from box_process_call/eval()
Date: Fri, 17 Jan 2020 10:47:25 +0300 [thread overview]
Message-ID: <20200117074725.GF24940@atlas> (raw)
In-Reply-To: <52419d26967890ace8245f46fdff0604f919a029.1579211601.git.v.shpilevoy@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [20/01/17 00:57]:
> box_process_call/eval() in the end check if there is an
> active transaction. If there is, it is rolled back, and
> an error is set.
>
> But rollback is not needed anymore, because anyway in
> the end of the request the fiber is stopped, and its
> not finished transaction is rolled back. Just setting
> of the error is enough.
(and lgtm)
This patch imho is necessary since it "seals" correctness of the
previous patch - if the previous patch is broken, after this
patch is applied, we're going to get assertion failures in
txn_init(). Very nice.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-01-17 7:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 21:54 [Tarantool-patches] [PATCH v2 0/3] Fiber storage leak Vladislav Shpilevoy
2020-01-16 21:54 ` [Tarantool-patches] [PATCH v2 1/3] fiber: unref fiber.storage via global Lua state Vladislav Shpilevoy
2020-01-17 7:30 ` Konstantin Osipov
2020-01-16 21:54 ` [Tarantool-patches] [PATCH v2 2/3] fiber: destroy fiber.storage created by iproto Vladislav Shpilevoy
2020-01-16 22:00 ` Cyrill Gorcunov
2020-01-17 7:47 ` Konstantin Osipov
2020-01-17 8:06 ` Cyrill Gorcunov
2020-01-17 7:45 ` Konstantin Osipov
2020-01-19 17:32 ` Vladislav Shpilevoy
2020-01-20 7:22 ` Konstantin Osipov
2020-01-20 19:15 ` Georgy Kirichenko
2020-01-21 22:21 ` Vladislav Shpilevoy
2020-01-21 22:32 ` Konstantin Osipov
2020-01-16 21:54 ` [Tarantool-patches] [PATCH v2 3/3] box: remove dead code from box_process_call/eval() Vladislav Shpilevoy
2020-01-17 7:46 ` Konstantin Osipov
2020-01-17 7:47 ` Konstantin Osipov [this message]
2020-01-17 17:41 ` Georgy Kirichenko
2020-01-19 17:32 ` Vladislav Shpilevoy
2020-01-20 19:21 ` Georgy Kirichenko
2020-01-18 19:27 ` [Tarantool-patches] [PATCH v2 0/3] Fiber storage leak Igor Munkin
2020-02-15 1:02 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117074725.GF24940@atlas \
--to=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 3/3] box: remove dead code from box_process_call/eval()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox