From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 2/3] fiber: destroy fiber.storage created by iproto
Date: Fri, 17 Jan 2020 01:00:33 +0300 [thread overview]
Message-ID: <20200116220033.GO31598@uranus> (raw)
In-Reply-To: <31e884f2b6d2ab7b222229f1b204fa067d63ae65.1579211601.git.v.shpilevoy@tarantool.org>
On Thu, Jan 16, 2020 at 10:54:22PM +0100, Vladislav Shpilevoy wrote:
...
> static int
> lbox_fiber_storage(struct lua_State *L)
> {
> struct fiber *f = lbox_checkfiber(L, 1);
> int storage_ref = f->storage.lua.ref;
> if (storage_ref <= 0) {
> + struct trigger *t = (struct trigger *)
> + malloc(sizeof(*t));
Vlad, maybe you could point me -- why do we need an explicit cast here?
next prev parent reply other threads:[~2020-01-16 22:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 21:54 [Tarantool-patches] [PATCH v2 0/3] Fiber storage leak Vladislav Shpilevoy
2020-01-16 21:54 ` [Tarantool-patches] [PATCH v2 1/3] fiber: unref fiber.storage via global Lua state Vladislav Shpilevoy
2020-01-17 7:30 ` Konstantin Osipov
2020-01-16 21:54 ` [Tarantool-patches] [PATCH v2 2/3] fiber: destroy fiber.storage created by iproto Vladislav Shpilevoy
2020-01-16 22:00 ` Cyrill Gorcunov [this message]
2020-01-17 7:47 ` Konstantin Osipov
2020-01-17 8:06 ` Cyrill Gorcunov
2020-01-17 7:45 ` Konstantin Osipov
2020-01-19 17:32 ` Vladislav Shpilevoy
2020-01-20 7:22 ` Konstantin Osipov
2020-01-20 19:15 ` Georgy Kirichenko
2020-01-21 22:21 ` Vladislav Shpilevoy
2020-01-21 22:32 ` Konstantin Osipov
2020-01-16 21:54 ` [Tarantool-patches] [PATCH v2 3/3] box: remove dead code from box_process_call/eval() Vladislav Shpilevoy
2020-01-17 7:46 ` Konstantin Osipov
2020-01-17 7:47 ` Konstantin Osipov
2020-01-17 17:41 ` Georgy Kirichenko
2020-01-19 17:32 ` Vladislav Shpilevoy
2020-01-20 19:21 ` Georgy Kirichenko
2020-01-18 19:27 ` [Tarantool-patches] [PATCH v2 0/3] Fiber storage leak Igor Munkin
2020-02-15 1:02 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116220033.GO31598@uranus \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 2/3] fiber: destroy fiber.storage created by iproto' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox