From: Nikita Pettik <korablev@tarantool.org> To: Maxim Kulis <bokuno@picodata.io> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH] vinyl: prohibit vinyl_level_size_ratio less than two Date: Wed, 15 Jan 2020 20:36:19 +0300 [thread overview] Message-ID: <20200115173619.GF7851@tarantool.org> (raw) In-Reply-To: <1578908907.647593657@f120.i.mail.ru> On 13 Jan 12:48, Maxim Kulis wrote: > Hi! > Thanks for your review. > Hi, Are you going to update your patch according to the review notes? Review process is described here: https://www.tarantool.io/en/doc/2.2/dev_guide/developer_guidelines/#how-to-submit-a-patch-for-review > >Четверг, 5 декабря 2019, 14:27 +03:00 от Nikita Pettik <korablev@tarantool.org>: > > > >On 02 Dec 19:11, Maksim Kulis wrote: > >> Change the minimum possible value of the variable vinyl_run_size_ratio to 2. > >> > >> Closes #3346 > >> --- > >> src/box/box.cc | 4 ++-- > >> test/box-tap/cfg.test.lua | 2 +- > >> 2 files changed, 3 insertions(+), 3 deletions(-) > > > >Hello. Thanks for the patch. > > > >Firsly, please update check of run_size_ratio during index options > >decode (see index_opts_decode()). > > > >I would also update assert() in vy_range_update_compaction_priority(): > >let's make it check that run_size_ratio always >= 2. > > > >Finally, I would add brief explanation to the commit message why > >run_size_ratio less than 2 is meaningless (for those who are not > >familiar with vinyl inner organization). > > > >> diff --git a/src/box/box.cc b/src/box/box.cc > >> index be2390335..e426fdab8 100644 > >> --- a/src/box/box.cc > >> +++ b/src/box/box.cc > >> @@ -589,9 +589,9 @@ box_check_vinyl_options(void) > >> tnt_raise(ClientError, ER_CFG, "vinyl_run_count_per_level", > >> "must be greater than 0"); > >> } > >> - if (run_size_ratio <= 1) { > >> + if (run_size_ratio < 2) { > >> tnt_raise(ClientError, ER_CFG, "vinyl_run_size_ratio", > >> - "must be greater than 1"); > >> + "must be greater than or uqual to 2"); > >> } > >> if (bloom_fpr <= 0 || bloom_fpr > 1) { > >> tnt_raise(ClientError, ER_CFG, "vinyl_bloom_fpr", > >> diff --git a/test/box-tap/cfg.test.lua b/test/box-tap/cfg.test.lua > >> index d529447bb..b68c6f17b 100755 > >> --- a/test/box-tap/cfg.test.lua > >> +++ b/test/box-tap/cfg.test.lua > >> @@ -46,7 +46,7 @@ invalid('vinyl_read_threads', 0) > >> invalid('vinyl_write_threads', 1) > >> invalid('vinyl_page_size', 0) > >> invalid('vinyl_run_count_per_level', 0) > >> -invalid('vinyl_run_size_ratio', 1) > >> +invalid('vinyl_run_size_ratio', 1.9) > >> invalid('vinyl_bloom_fpr', 0) > >> invalid('vinyl_bloom_fpr', 1.1) > >> > >> -- > >> 2.17.1 > >> > > > -- > Maxim Kulis
next prev parent reply other threads:[~2020-01-15 17:36 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-02 16:11 Maksim Kulis 2019-12-05 11:27 ` Nikita Pettik [not found] ` <1578908907.647593657@f120.i.mail.ru> 2020-01-15 17:36 ` Nikita Pettik [this message] 2020-01-24 11:04 ` Maxim Kulis 2020-01-31 0:24 ` Nikita Pettik 2020-02-04 0:27 ` Maxim Kulis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200115173619.GF7851@tarantool.org \ --to=korablev@tarantool.org \ --cc=bokuno@picodata.io \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] vinyl: prohibit vinyl_level_size_ratio less than two' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox