From: Cyrill Gorcunov <gorcunov@gmail.com>
To: tml <tarantool-patches@dev.tarantool.org>
Subject: [Tarantool-patches] [PATCH 2/3] box/console: handle empty output format
Date: Wed, 15 Jan 2020 11:56:04 +0300 [thread overview]
Message-ID: <20200115085605.32307-3-gorcunov@gmail.com> (raw)
In-Reply-To: <20200115085605.32307-1-gorcunov@gmail.com>
In case if output format is not specified we should exit
with more readable error message.
Fixes #4638
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
src/box/lua/console.lua | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/box/lua/console.lua b/src/box/lua/console.lua
index a4a36c625..17e2c91b2 100644
--- a/src/box/lua/console.lua
+++ b/src/box/lua/console.lua
@@ -126,6 +126,9 @@ end
local function parse_output(value)
local fmt, opts
+ if not value then
+ return 'Specify output format: lua or yaml.'
+ end
if value:match("([^,]+),([^,]+)") ~= nil then
fmt, opts = value:match("([^,]+),([^,]+)")
else
--
2.20.1
next prev parent reply other threads:[~2020-01-15 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 8:56 [Tarantool-patches] [PATCH v2 0/3] box/console: Fix multireturn and empty output Cyrill Gorcunov
2020-01-15 8:56 ` [Tarantool-patches] [PATCH 1/3] box/console: handle multireturn in lua mode Cyrill Gorcunov
2020-01-15 8:56 ` Cyrill Gorcunov [this message]
2020-01-15 8:56 ` [Tarantool-patches] [PATCH 3/3] test/app-tap: add console_lua test Cyrill Gorcunov
2020-01-17 18:59 ` Alexander Turenko
2020-01-19 14:09 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115085605.32307-3-gorcunov@gmail.com \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/3] box/console: handle empty output format' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox