Re: [Tarantool-patches] [PATCH] box: frommap() bug fix

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 14 янв 13:49, Chris Sosnin wrote:
> (backport version for 1.10)
> This patch is almost the same as the one I've sent
> for 2.3, the only difference is that here it is needed
> to change tuple interface to make it possible to borrow
> the error message after the luaT_tuple_new call.
> 
> - If an optional argument is provided for
>   space_object:frommap() (which is {table = true|false}),
>   type match for first arguments is omitted, which is
>   incorrect. We should return the result only after making
>   sure it is possible to build a tuple.
> 
> - If there is a type mismatch, however, frommap() does not
>   return nil, err as it is mentioned in the description, so we
>   change it to be this way.
> 
> Closes #4262
> ---
> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4262-frommap-fix-1-10
> issue: https://github.com/tarantool/tarantool/issues/4262

I've checked your patch into 1.10, 2.2, 2.3 and master.

--
Regards, Kirill Yukhin