From: Nikita Pettik <korablev@tarantool.org> To: Mergen Imeev <imeevma@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v2 1/1] sql: make NUMBER to be union of SQL numeric types Date: Mon, 13 Jan 2020 15:58:29 +0300 [thread overview] Message-ID: <20200113125829.GB7851@tarantool.org> (raw) In-Reply-To: <20191231094611.GA9514@tarantool.org> On 31 Dec 12:46, Mergen Imeev wrote: > Hi! Thank you for review. My answer below. > > On Tue, Dec 31, 2019 at 10:56:07AM +0200, Nikita Pettik wrote: > > On 31 Dec 11:50, imeevma@tarantool.org wrote: > > > This patch makes number to be union of UNSIGNED, INTEGER and > > > DOUBLE numeric types. > > > > > > Closes #4233 > > > Closes #4463 > > > > Please, explain in details changes in explicit/implicit > > casts behaviour. > > > Fixed: > > commit 492646da4f781b863e5e3e488a0be53f31d28964 > Author: Mergen Imeev <imeevma@gmail.com> > Date: Sat Oct 26 17:27:53 2019 +0300 > > sql: make NUMBER to be union of SQL numeric types > > This patch makes number to be union of UNSIGNED, INTEGER and > DOUBLE numeric types. > > Closes #4233 > Closes #4463 > > @TarantoolBot document > Title: NUMBER type in SQL. Could you please intead of 3 paragraphs just include following changelog list: "This patch makes definition of NUMBER type be consistent with NoSQL. Previously (for historic reasons) in half-cases NUMBER served as a synonym of DOUBLE type. After patch is applied following will change: - CAST AS NUMBER operation no more longer results in any value change in case value is already of numeric type. Example: Obsolete behaviour: SELECT CAST(922337206854774800 AS NUMBER); Result: 9223372036854774784 New behaviour: SELECT CAST(922337206854774800 AS NUMBER); Result: 9223372036854774800LL - ... " Or group implicit/explicit cast changes. Text below is quite compicated to perceive (IMHO). > > The NUMBER type in SQL is the union of all currently available > numeric types in SQL: INTEGER, UNSIGNED, and DOUBLE. The types > INTEGER and DOUBLE can be called subtypes of type NUMBER. Any > value of type NUMBER has a subtype of INTEGER or DOUBLE. When > any numeric value is implicitly or explicitly casted to NUMBER, > the only thing that can change is its type. Its type will become > NUMBER. When a value of type NUMBER is cast explicitly or > implicitly to other numeric types, the rules applicable to the > cast are determined by the subtype of the value. > > If a value of type STRING can be implicitly cast to value of > type INTEGER or DOUBLE, then this value can be cast explicitly > and implicitly to a value of type NUMBER. If this value can be > implicitly cast to INTEGER, then its subtype will be INTEGER. > The subtype will be DOUBLE in another case. > > If a value of type VARBINARY can be explicitly cast to type > INTEGER or DOUBLE, then this value can be explicitly cast to a > value of type NUMBER. If this value can be explicitly cast to > INTEGER, then its subtype will be INTEGER. The subtype will be > DOUBLE in another case. > > > ---
next prev parent reply other threads:[~2020-01-13 12:58 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-31 8:50 imeevma 2019-12-31 8:56 ` Nikita Pettik 2019-12-31 9:46 ` Mergen Imeev 2020-01-13 12:58 ` Nikita Pettik [this message] 2020-01-17 8:06 ` Mergen Imeev 2020-01-22 13:26 ` Nikita Pettik 2020-01-23 13:40 ` Mergen Imeev 2020-01-28 16:23 ` Nikita Pettik 2020-02-03 9:52 ` Mergen Imeev 2020-02-04 12:56 ` Nikita Pettik 2020-02-09 21:29 ` Alexander Turenko 2020-02-09 23:45 ` Nikita Pettik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200113125829.GB7851@tarantool.org \ --to=korablev@tarantool.org \ --cc=imeevma@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 1/1] sql: make NUMBER to be union of SQL numeric types' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox