From: Igor Munkin <imun@tarantool.org> To: "Alexander V. Tikhonov" <avtikhon@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v1 2/2] test: rename test files Date: Mon, 13 Jan 2020 15:05:11 +0300 [thread overview] Message-ID: <20200113120511.GG31304@tarantool.org> (raw) In-Reply-To: <8da0c2594f851f1dac290d9288f1fee65fc53b39.1576485551.git.avtikhon@tarantool.org> Sasha, Thanks for the patch! IMHO gh prefix can be used for the issues filed in Tarantool queue and is excess for the tests related to issues from other queues. Otherwise e.g. tnt prefix can be used for the issues origined to Tarantool and gh prefix can be dropped at all. The naming you propose within this patch looks too long for me. On 16.12.19, Alexander V. Tikhonov wrote: > Renamed test files in the following way: > [gh-[external repo]-<number>-]comment.test.lua > where "external repo" is github repository: > lj - luajit/luajit > lrc - openresty/lua-resty-core The openresty queue is located in openresty/luajit2 repo. Furthermore or (for openresty) feems to be more correct for the corresponding prefix. > > Close #4655 > --- > test/{gh.test.lua => gh-3196-incorrect-string-length.test.lua} | 0 > ...mm_tarantool_4560.test.lua => gh-4560-pairsmm-is-set.test.lua} | 0 > ...n_bug_LuaJIT_494.test.lua => gh-lj-494-infinite-loop.test.lua} | 0 > ...JIT_505.test.lua => gh-lj-505-fold-icorrect-behavior.test.lua} | 0 > ...JIT_524.test.lua => gh-lj-524-fold-icorrect-behavior.test.lua} | 0 > ...{unsink_64_kptr.test.lua => gh-lrc-64-unsink-64-kptr.test.lua} | 0 > 6 files changed, 0 insertions(+), 0 deletions(-) > rename test/{gh.test.lua => gh-3196-incorrect-string-length.test.lua} (100%) > rename test/{pairsmm_tarantool_4560.test.lua => gh-4560-pairsmm-is-set.test.lua} (100%) > rename test/{table_chain_bug_LuaJIT_494.test.lua => gh-lj-494-infinite-loop.test.lua} (100%) table-chain-infinite-loop looks more correct. > rename test/{fold_bug_LuaJIT_505.test.lua => gh-lj-505-fold-icorrect-behavior.test.lua} (100%) > rename test/{fold_bug_LuaJIT_524.test.lua => gh-lj-524-fold-icorrect-behavior.test.lua} (100%) > rename test/{unsink_64_kptr.test.lua => gh-lrc-64-unsink-64-kptr.test.lua} (100%) > > diff --git a/test/gh.test.lua b/test/gh-3196-incorrect-string-length.test.lua > similarity index 100% > rename from test/gh.test.lua > rename to test/gh-3196-incorrect-string-length.test.lua > diff --git a/test/pairsmm_tarantool_4560.test.lua b/test/gh-4560-pairsmm-is-set.test.lua > similarity index 100% > rename from test/pairsmm_tarantool_4560.test.lua > rename to test/gh-4560-pairsmm-is-set.test.lua > diff --git a/test/table_chain_bug_LuaJIT_494.test.lua b/test/gh-lj-494-infinite-loop.test.lua > similarity index 100% > rename from test/table_chain_bug_LuaJIT_494.test.lua > rename to test/gh-lj-494-infinite-loop.test.lua > diff --git a/test/fold_bug_LuaJIT_505.test.lua b/test/gh-lj-505-fold-icorrect-behavior.test.lua > similarity index 100% > rename from test/fold_bug_LuaJIT_505.test.lua > rename to test/gh-lj-505-fold-icorrect-behavior.test.lua > diff --git a/test/fold_bug_LuaJIT_524.test.lua b/test/gh-lj-524-fold-icorrect-behavior.test.lua > similarity index 100% > rename from test/fold_bug_LuaJIT_524.test.lua > rename to test/gh-lj-524-fold-icorrect-behavior.test.lua > diff --git a/test/unsink_64_kptr.test.lua b/test/gh-lrc-64-unsink-64-kptr.test.lua > similarity index 100% > rename from test/unsink_64_kptr.test.lua > rename to test/gh-lrc-64-unsink-64-kptr.test.lua test/fix_string_find_recodring.test.lua is missing. > -- > 2.17.1 > -- Best regards, IM
next prev parent reply other threads:[~2020-01-13 12:07 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-16 8:43 [Tarantool-patches] [PATCH v1 0/2] Correct luajit tests Alexander V. Tikhonov 2019-12-16 8:43 ` [Tarantool-patches] [PATCH v1 1/2] test: cleanup tests code Alexander V. Tikhonov 2020-01-13 12:04 ` Igor Munkin 2020-02-27 13:38 ` Alexander Tikhonov 2019-12-16 8:43 ` [Tarantool-patches] [PATCH v1 2/2] test: rename test files Alexander V. Tikhonov 2020-01-13 12:05 ` Igor Munkin [this message] 2020-02-27 13:39 ` Alexander Tikhonov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200113120511.GG31304@tarantool.org \ --to=imun@tarantool.org \ --cc=avtikhon@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1 2/2] test: rename test files' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox