From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] fiber: set diag error on madvise, mprotect fails
Date: Sat, 11 Jan 2020 10:38:39 +0300 [thread overview]
Message-ID: <20200111073839.GH2436@uranus> (raw)
In-Reply-To: <43fa7862-777b-1717-71e0-ccb8865d23e5@tarantool.org>
On Sat, Jan 11, 2020 at 10:03:33AM +0300, Oleg Babin wrote:
> Hello, thanks for your patch!
>
> Our documentation doesn't contain any mentions that fiber.create can fail.
>
> Could you please file an issue (or may be doc bot request) with
> description in what cases user
>
> can expect that fiber.create will fail. Usually users don't use pcall for
> fiber.create and this fact can
> be quite unexpected for them.
Will do. Thanks!
next prev parent reply other threads:[~2020-01-11 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 14:27 Cyrill Gorcunov
2020-01-11 7:03 ` Oleg Babin
2020-01-11 7:38 ` Cyrill Gorcunov [this message]
2020-01-12 9:27 ` Cyrill Gorcunov
2020-01-15 13:35 ` Alexander Turenko
2020-01-15 13:39 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200111073839.GH2436@uranus \
--to=gorcunov@gmail.com \
--cc=olegrok@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] fiber: set diag error on madvise, mprotect fails' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox