From: Igor Munkin <imun@tarantool.org> To: HustonMmmavr <huston.mavr@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH] fio: fix race condition in mktree Date: Fri, 10 Jan 2020 14:33:40 +0300 [thread overview] Message-ID: <20200110113340.GD31304@tarantool.org> (raw) In-Reply-To: <20191217155223.13153-1-huston.mavr@gmail.com> Hello, Thanks for the patch. Here are some general comments for the patch: * Why this patch is necessary? I see no words in documentation about the concurrent path creation and corresponding errors. Therefore considering our docs everything works as described. If you see this as a gray zone, please file a ticket to tarantool/doc[1] repo for adjusting the fio docs regarding the changes you provide. * If you are affected with such behaviour please describe the problem you faced with a bit more words in the commit message (since the word "parallel" is ambigous for this case) and provide a test case regarding your fix if possible. There are also several comments below, please also consider them. On 17.12.19, HustonMmmavr wrote: > This patch fixes a bug that occours when two instances calls Typo: s/occours/occurs/. Typo: s/calls/call/. > fio.mktree for the same directory in parallel. > > Closes #4660 > --- > branch: https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-4660-fix-fio-mktree-race > issue: https://github.com/tarantool/tarantool/issues/4660 > > src/lua/fio.lua | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lua/fio.lua b/src/lua/fio.lua > index cb224f3d0..c9aeac951 100644 > --- a/src/lua/fio.lua > +++ b/src/lua/fio.lua > @@ -364,7 +364,7 @@ fio.mktree = function(path, mode) > local stat = fio.stat(current_dir) > if stat == nil then > local st, err = fio.mkdir(current_dir, mode) > - if err ~= nil then > + if err ~= nil and not fio.path.is_dir(current_dir) then Side note: it's weird to check the second optional result value to detect the failure instead of the first one. Feel free to ignore. > return false, string.format("Error creating directory %s: %s", > current_dir, tostring(err)) > end > -- > 2.23.0 > [1]: https://github.com/tarantool/doc -- Best regards, IM
prev parent reply other threads:[~2020-01-10 11:35 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-17 15:52 HustonMmmavr 2020-01-10 11:33 ` Igor Munkin [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200110113340.GD31304@tarantool.org \ --to=imun@tarantool.org \ --cc=huston.mavr@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] fio: fix race condition in mktree' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox