From: Sergey Kaplun <skaplun@tarantool.org> To: tarantool-patches@dev.tarantool.org Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [Tarantool-patches] [PATCH] refactoring: drop excess 16Kb bss buffer Date: Thu, 9 Jan 2020 23:06:36 +0300 [thread overview] Message-ID: <20200109200636.26308-1-skaplun@tarantool.org> (raw) We already have 12Kb thread-safe static buffer in `lib/small/small/static.h`, that can be used instead of 16Kb bss buffer in `src/lib/core/backtrace.cc` for backtrace payload. Closes #4650 --- branch: https://github.com/tarantool/tarantool/tree/skaplun/drop-bss-buff issue: https://github.com/tarantool/tarantool/issues/4650 src/lib/core/backtrace.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lib/core/backtrace.cc b/src/lib/core/backtrace.cc index 77f77b05c..eabd986df 100644 --- a/src/lib/core/backtrace.cc +++ b/src/lib/core/backtrace.cc @@ -47,6 +47,7 @@ #include <libunwind.h> #include "small/region.h" +#include "small/static.h" /* * We use a global static buffer because it is too late to do any * allocation when we are printing backtrace and fiber stack is @@ -55,8 +56,6 @@ #define BACKTRACE_NAME_MAX 200 -static char backtrace_buf[4096 * 4]; - static __thread struct region cache_region; static __thread struct mh_i64ptr_t *proc_cache = NULL; @@ -140,8 +139,9 @@ backtrace() unw_getcontext(&unw_context); unw_cursor_t unw_cur; unw_init_local(&unw_cur, &unw_context); + char *backtrace_buf = (char *)static_alloc(SMALL_STATIC_SIZE); char *p = backtrace_buf; - char *end = p + sizeof(backtrace_buf) - 1; + char *end = p + SMALL_STATIC_SIZE - 1; int unw_status; *p = '\0'; while ((unw_status = unw_step(&unw_cur)) > 0) { -- 2.24.1
next reply other threads:[~2020-01-09 20:06 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-09 20:06 Sergey Kaplun [this message] 2020-01-09 20:15 ` Cyrill Gorcunov 2020-01-09 20:18 ` Cyrill Gorcunov 2020-01-13 22:00 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200109200636.26308-1-skaplun@tarantool.org \ --to=skaplun@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] refactoring: drop excess 16Kb bss buffer' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox