From: Kirill Yukhin <kyukhin@tarantool.org>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] test: fix and split flaky join_vclock test
Date: Tue, 31 Dec 2019 12:12:21 +0300 [thread overview]
Message-ID: <20191231091221.ihofod4j5smgrpxl@tarantool.org> (raw)
In-Reply-To: <b5fe5871c5ae6c74fdd24f4717d57a2b702e0436.1577726517.git.i.kosarev@tarantool.org>
Hello,
On 30 дек 20:47, Ilya Kosarev wrote:
> join_vclock test is assumed to verify that changes are not being lost
> on the replica. Due to this the test is changed to explicitly check
> that all changes on master are applied on replica.
> Previously this test was also indirectly verifying that changes are
> being applied in the correct order. Now there is separate test for
> this, called replica_apply_order.
> As far as changed join_vclock test might fail due to #4669, we are now
> creating cluster out of fresh instances instead of using default
> instance. Considering mentioned fixes it is not fragile anymore.
>
> Closes #4160
I've checked your patch into 1.10, 2.2 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-12-31 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 17:46 [Tarantool-patches] [PATCH 0/2] fix vlock obtainment on join & " Ilya Kosarev
2019-12-30 17:47 ` [Tarantool-patches] [PATCH 1/2] relay: fix vclock obtainment on join Ilya Kosarev
2019-12-31 9:11 ` Kirill Yukhin
2019-12-30 17:47 ` [Tarantool-patches] [PATCH 2/2] test: fix and split flaky join_vclock test Ilya Kosarev
2019-12-31 9:12 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191231091221.ihofod4j5smgrpxl@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] test: fix and split flaky join_vclock test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox