From: Kirill Yukhin <kyukhin@tarantool.org>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/2] relay: fix vclock obtainment on join
Date: Tue, 31 Dec 2019 12:11:53 +0300 [thread overview]
Message-ID: <20191231091153.2rn6dmqbnvbfgd5o@tarantool.org> (raw)
In-Reply-To: <c378dddea60c748d9c9ddaacea8eb6bbabae5180.1577726517.git.i.kosarev@tarantool.org>
Hello,
On 30 дек 20:47, Ilya Kosarev wrote:
> In case of high load vclock used to join replica could be in advance
> comparing to an actual WAL. Therefore replica could have missed some
> tuples from master. In order to fix this wal_sync is updated so that
> now we can obtain up to date vclock on the flushed state using it.
>
> Prerequisites #4160
> ---
> src/box/relay.cc | 7 +++----
> src/box/vinyl.c | 4 ++--
> src/box/wal.c | 23 +++++++++++++++++------
> src/box/wal.h | 4 +++-
> 4 files changed, 25 insertions(+), 13 deletions(-)
I've checked your patch into master.
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2019-12-31 9:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 17:46 [Tarantool-patches] [PATCH 0/2] fix vlock obtainment on join & join_vclock test Ilya Kosarev
2019-12-30 17:47 ` [Tarantool-patches] [PATCH 1/2] relay: fix vclock obtainment on join Ilya Kosarev
2019-12-31 9:11 ` Kirill Yukhin [this message]
2019-12-30 17:47 ` [Tarantool-patches] [PATCH 2/2] test: fix and split flaky join_vclock test Ilya Kosarev
2019-12-31 9:12 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191231091153.2rn6dmqbnvbfgd5o@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/2] relay: fix vclock obtainment on join' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox