From: Mergen Imeev <imeevma@tarantool.org> To: Nikita Pettik <korablev@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v5 3/3] box: add SQL settings to _session_settings Date: Mon, 30 Dec 2019 15:41:43 +0300 [thread overview] Message-ID: <20191230124143.GA28330@tarantool.org> (raw) In-Reply-To: <20191230123813.GA28185@tarantool.org> Sorry, forgot to answer one question. The answer below. On Mon, Dec 30, 2019 at 03:38:13PM +0300, Mergen Imeev wrote: > Hi! Thank you fore review! My answers below. > > On Mon, Dec 30, 2019 at 01:21:28PM +0200, Nikita Pettik wrote: > > On 27 Dec 17:05, imeevma@tarantool.org wrote: > > > Part of #4511 > > > > > > @TarantoolBot document > > > Title: _session_settings system space > > > The _session_settings system space used to view or change session > > > settings. > > > > > > This space uses a new engine. This allows us to create tuples on > > > the fly when the get() or select() methods are called. This > > > engine does not support the insert(), replace(), and delete() > > > methods. The only way to change the setting value is update(), > > > which can only be used with the "=" operation. > > > > Do you have instruction for developers how to insert to this space > > new values and remove obsolete ones? Sooner or later we will have to > > introduce new SQL settings and clean-up unused. > > > There is no such instruction for now. I will write an > article in our wiki a bit later. > > > > Because space creates a tuple on the fly, it allows us to get a > > > tuple without saving it anywhere. But this means that every time > > > we get a tuple from this system space, it is a new tuple, even if > > > they look the same: > > > > > > tarantool> s = box.space._session_settings > > > tarantool> name = 'sql_default_engine' > > > tarantool> s:get({name}) == s:get({name}) > > > --- > > > - false > > > ... > > > > > > Currently, this space contains only SQL settings, since the only > > > session settings are SQL settings. > > > > > > List of currently available session settings: > > > > > > sql_default_engine > > > sql_defer_foreign_keys > > > sql_full_column_names > > > sql_full_metadata > > > sql_recursive_triggers > > > sql_reverse_unordered_selects > > > > Is user capable of setting default values for these options? > > > No, at least for now. Even if user will be able to do this, > the default value of setting is a global setting. At least > until we will be able to differentiate users. > > > > Debug build also have debug settings that could be obtained from > > > this sysview: > > > > > > sql_parser_trace > > > sql_select_trace > > > sql_trace > > > sql_vdbe_addoptrace > > > sql_vdbe_debug > > > sql_vdbe_eqp > > > sql_vdbe_listing > > > sql_vdbe_trace > > > sql_where_trace > > > > Imho there are too many debug options. We can easily merge > > half of them (where + select traces, vdbe eqp + debug). I agree, but I suggest to leave this to the next release. Should I create an issue? > > What is more, I think different set of options on debug and > > release builds is quite error prone. Mb it is worth keeping > > debug options all the time, but disallow setting their values > > to true? > > > It is possible, but I don’t think there will be problems, > since there are no numerical identifiers. Still, I do not > think that user should be able to see internal settings.
next prev parent reply other threads:[~2019-12-30 12:41 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-27 14:05 [Tarantool-patches] [PATCH v5 0/3] Introduce _session_setting system space imeevma 2019-12-27 14:05 ` [Tarantool-patches] [PATCH v5 1/3] box: introduce 'virtual' engine imeevma 2019-12-27 21:55 ` Nikita Pettik 2019-12-28 11:35 ` Alexander Turenko 2019-12-29 15:43 ` Mergen Imeev 2019-12-27 14:05 ` [Tarantool-patches] [PATCH v5 2/3] box: introduce _session_settings system space imeevma 2019-12-27 14:05 ` [Tarantool-patches] [PATCH v5 3/3] box: add SQL settings to _session_settings imeevma 2019-12-30 11:21 ` Nikita Pettik 2019-12-30 12:38 ` Mergen Imeev 2019-12-30 12:41 ` Mergen Imeev [this message] 2019-12-30 13:15 ` Nikita Pettik 2019-12-30 16:48 ` Mergen Imeev 2019-12-30 13:11 ` Nikita Pettik 2019-12-27 14:55 ` [Tarantool-patches] [PATCH v5 0/3] Introduce _session_setting system space Vladislav Shpilevoy 2019-12-29 15:39 imeevma 2019-12-29 15:39 ` [Tarantool-patches] [PATCH v5 3/3] box: add SQL settings to _session_settings imeevma
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191230124143.GA28330@tarantool.org \ --to=imeevma@tarantool.org \ --cc=korablev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v5 3/3] box: add SQL settings to _session_settings' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox