From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v6] test: fix flaky socket test
Date: Mon, 30 Dec 2019 11:59:46 +0300 [thread overview]
Message-ID: <20191230085946.ikbbgpb6lspue6rh@tkn_work_nb> (raw)
In-Reply-To: <20191227123720.32053-1-i.kosarev@tarantool.org>
Thank you!
LGTM.
WBR, Alexander Turenko.
On Fri, Dec 27, 2019 at 03:37:20PM +0300, Ilya Kosarev wrote:
> socket.test had a number of flaky problems:
> - socket readiness expectation & read timeouts
> - race conditions on socket shutdown in emulation test cases
> - UDP datagrams losses on mac os
> - excessive random port searches
> Now they are solved. 127.0.0.1 is now used instead of 0.0.0.0 or
> localhost to prevent wrong connections where appropriate. Socket test
> is not fragile anymore.
>
> Closes #4426
> Closes #4451
> Closes #4469
> ---
> Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4426-4451-fix-socket-test
> Issues: https://github.com/tarantool/tarantool/issues/4426
> https://github.com/tarantool/tarantool/issues/4451
> https://github.com/tarantool/tarantool/issues/4469
prev parent reply other threads:[~2019-12-30 8:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 12:37 Ilya Kosarev
2019-12-30 8:59 ` Alexander Turenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191230085946.ikbbgpb6lspue6rh@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v6] test: fix flaky socket test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox