Re: [Tarantool-patches] [PATCH v2 test-run 1/1] sql: add another way to change SQL default engine

[Alexander Turenko <alexander.turenko@tarantool.org>]

> >> diff --git a/lib/tarantool_server.py b/lib/tarantool_server.py
> >> index 6f71b5b..20a398e 100644
> >> --- a/lib/tarantool_server.py
> >> +++ b/lib/tarantool_server.py
> >> @@ -145,12 +145,19 @@ class LuaTest(Test):
> >>              return True
> >>  
> >>          engine = self.run_params['engine']
> >> -        command = "pragma sql_default_engine='{}'".format(engine)
> >> -        result = self.send_command(command, ts, 'sql')
> >> -        result = result.replace('\r\n', '\n')
> >> -        if result != '---\n- row_count: 0\n...\n':
> >> -            sys.stdout.write(result)
> >> -            return False
> >> +
> >> +        command_new = ("UPDATE \"_session_settings\" SET \"value\" = '{}' " + \
> >> +                       "WHERE \"name\" = 'sql_default_engine'").format(engine)
> >> +        result_new = self.send_command(command_new, ts, 'sql')
> >> +        result_new = result_new.replace('\r\n', '\n')
> >> +
> >> +        command_old = "pragma sql_default_engine='{}'".format(engine)
> >> +        result_old = self.send_command(command_old, ts, 'sql')
> >> +        result_old = result_old.replace('\r\n', '\n')
> >> +        if result_new != '---\n- row_count: 1\n...\n':
> >> +            if result_old != '---\n- row_count: 0\n...\n':
> >> +                sys.stdout.write(result_old)
> >> +                return False
> >
> > I would make it like so:
> >
> > 1. Send "pragma ...", await a result.
> >    - If succeeds, return True.
> >    - Otherwise proceed with the step 2.
> > 2. Send "UPDATE ...", await a result.
> >    - If succeeds, return True.
> >    - Otherwise return False.
> >
> Fixed.

Ouch, occasionally I misdirected you. Sorry. I intend to say that we
should send the new-style command first and only then (if it fails) send
old-style "pragma ..." command.

This way we'll optimize the case when the new tarantool is tested that
will be most often case after some time.

> > This way we'll save one extra hop on a fresh tarantool. Not so big
> > overhead for an action that is run once for a test, but we can overcome
> > it and pay nothing, so it looks worthful for me.