Re: [Tarantool-patches] [PATCH v5 1/3] box: introduce 'virtual' engine

[Mergen Imeev <imeevma@tarantool.org>]

Hi! Thank you for review. I extended commit-messages a bit
and re-send a patch-set. Also, I renamed new engine from
'virtual' to 'service'.

On Fri, Dec 27, 2019 at 11:55:18PM +0200, Nikita Pettik wrote:
> On 27 Dec 17:05, imeevma@tarantool.org wrote:
> > This patch introduces a new engine called "virtual" that will be
> > used to create a new system space.
> 
> Such a descriptive commit message...Please, add either rfc or extend
> commit message to get others a change to dive into your patch:
> why do you need that engine, why alternatives are not suitable and so
> on and so forth. It's not only about this patch, but the next one
> as well.
> 
> As an alternative to 'virtual' name I can suggest 'service', 'system'
> (not so good since we already have 'sysview'), 'sysspace' (similar to
> 'sysview').
>  
> > +static struct space *
> > +virtual_engine_create_space(struct engine *engine, struct space_def *def,
> > +			    struct rlist *key_list)
> > +{
> > +	(void)engine;
> > +	(void)def;
> > +	(void)key_list;
> > +	/* There are currently no spaces with this engine. */
> > +	diag_set(ClientError, ER_UNSUPPORTED, "Tarantool",
> > +		 "spaces with this engine.");
> 
> -> with 'virtual' engine.
>