Tarantool development patches archive
 help / color / mirror / Atom feed
From: Nikita Pettik <korablev@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] sql: display line and position in syntax errors
Date: Sun, 29 Dec 2019 01:05:40 +0200	[thread overview]
Message-ID: <20191228230540.GA44517@tarantool.org> (raw)
In-Reply-To: <20191227171415.spx4aeobyadaj4li@tarantool.org>

On 27 Dec 20:14, Kirill Yukhin wrote:
> On 27 дек 19:07, Nikita Pettik wrote:
> > On 11 Dec 17:36, Nikita Pettik wrote:
> > > When it comes for huge queries, it may turn out to be useful to see
> > > exact position of occurred error. Hence, let's now display line and
> > > position within line near which syntax error takes place. Note that it
> > > can be done only during parsing process (since AST can be analysed only
> > > after its construction is completed), so most of semantic errors still
> > > don't contain position. A few errors have been reworked to match new
> > > formatting patterns.
> > > 
> > > First iteration of this patch is implemented by @romanhabibov
> > > 
> > > Closes #2611
> > > ---
> > > Branch: https://github.com/tarantool/tarantool/tree/np/gh-2611-line-pos-syntax-error
> > > Issue: https://github.com/tarantool/tarantool/issues/2611
> > > v1: https://lists.tarantool.org/pipermail/tarantool-patches/2019-October/011841.html
> > 
> > If nobody has objections (concerning new error messages patterns),
> > I am going to push it.
> 
> Sure.

Pushed to master.
 
> --
> Regards, Kirill Yukhin
> 

      reply	other threads:[~2019-12-28 23:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 14:36 Nikita Pettik
2019-12-27 17:07 ` Nikita Pettik
2019-12-27 17:14   ` Kirill Yukhin
2019-12-28 23:05     ` Nikita Pettik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191228230540.GA44517@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] sql: display line and position in syntax errors' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox