From: Nikita Pettik <korablev@tarantool.org> To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v5 1/3] box: introduce 'virtual' engine Date: Fri, 27 Dec 2019 23:55:18 +0200 [thread overview] Message-ID: <20191227215518.GM18639@tarantool.org> (raw) In-Reply-To: <002eae0ce1f0c7f28b5ef43236e069172942fdae.1577455413.git.imeevma@gmail.com> On 27 Dec 17:05, imeevma@tarantool.org wrote: > This patch introduces a new engine called "virtual" that will be > used to create a new system space. Such a descriptive commit message...Please, add either rfc or extend commit message to get others a change to dive into your patch: why do you need that engine, why alternatives are not suitable and so on and so forth. It's not only about this patch, but the next one as well. As an alternative to 'virtual' name I can suggest 'service', 'system' (not so good since we already have 'sysview'), 'sysspace' (similar to 'sysview'). > +static struct space * > +virtual_engine_create_space(struct engine *engine, struct space_def *def, > + struct rlist *key_list) > +{ > + (void)engine; > + (void)def; > + (void)key_list; > + /* There are currently no spaces with this engine. */ > + diag_set(ClientError, ER_UNSUPPORTED, "Tarantool", > + "spaces with this engine."); -> with 'virtual' engine.
next prev parent reply other threads:[~2019-12-27 21:55 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-27 14:05 [Tarantool-patches] [PATCH v5 0/3] Introduce _session_setting system space imeevma 2019-12-27 14:05 ` [Tarantool-patches] [PATCH v5 1/3] box: introduce 'virtual' engine imeevma 2019-12-27 21:55 ` Nikita Pettik [this message] 2019-12-28 11:35 ` Alexander Turenko 2019-12-29 15:43 ` Mergen Imeev 2019-12-27 14:05 ` [Tarantool-patches] [PATCH v5 2/3] box: introduce _session_settings system space imeevma 2019-12-27 14:05 ` [Tarantool-patches] [PATCH v5 3/3] box: add SQL settings to _session_settings imeevma 2019-12-30 11:21 ` Nikita Pettik 2019-12-30 12:38 ` Mergen Imeev 2019-12-30 12:41 ` Mergen Imeev 2019-12-30 13:15 ` Nikita Pettik 2019-12-30 16:48 ` Mergen Imeev 2019-12-30 13:11 ` Nikita Pettik 2019-12-27 14:55 ` [Tarantool-patches] [PATCH v5 0/3] Introduce _session_setting system space Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191227215518.GM18639@tarantool.org \ --to=korablev@tarantool.org \ --cc=imeevma@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v5 1/3] box: introduce '\''virtual'\'' engine' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox