From: Nikita Pettik <korablev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] sql: fix index consideration with INDEXED BY clause
Date: Fri, 27 Dec 2019 16:20:43 +0200 [thread overview]
Message-ID: <20191227142043.GJ18639@tarantool.org> (raw)
In-Reply-To: <20191227114824.GH18639@tarantool.org>
On 27 Dec 13:48, Nikita Pettik wrote:
> On 27 Dec 14:31, Vladislav Shpilevoy wrote:
> > Hi! Thanks for the patch! LGTM.
>
> Pushed to master.
I've also backported to 2.2 (since without this fix INDEXED BY is
almost useless).
> > On 26/12/2019 01:48, Nikita Pettik wrote:
> > > Accidentally, number of indexes to be considered during query planning
> > > in presence of INDEXED BY is calculated wrong. Instead of one (INDEXED
> > > BY is not a hint but requirement) index to be used (which is indicated
> > > in INDEXED BY clause), all space indexes take part in query planning.
> > > There are not so many tests checking this feature, so unfortunately this
> > > bug was hidden. Let's fix it and force only one index to be used in QP
> > > in case of INDEXED BY clause.
> > > ---
> > > Branch: https://github.com/tarantool/tarantool/tree/np/sql-indexed-by-fix
prev parent reply other threads:[~2019-12-27 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 0:48 Nikita Pettik
2019-12-27 11:31 ` Vladislav Shpilevoy
2019-12-27 11:48 ` Nikita Pettik
2019-12-27 14:20 ` Nikita Pettik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191227142043.GJ18639@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] sql: fix index consideration with INDEXED BY clause' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox