From: Nikita Pettik <korablev@tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v1 0/2] Add DOUBLE type to SQL Date: Fri, 27 Dec 2019 14:37:24 +0200 [thread overview] Message-ID: <20191227123724.GI18639@tarantool.org> (raw) In-Reply-To: <63a11f3f-f8aa-166e-feab-85746e8b08a0@tarantool.org> On 23 Dec 20:16, Vladislav Shpilevoy wrote: > Thanks for the patch! LGTM. > > Nikita, please, do a second review. Mergen fixed nits I had noticed. Pushed to master. > On 21/12/2019 17:03, imeevma@tarantool.org wrote: > > This patch-set adds the DOUBLE type to SQL. In the first patch of > > the set, the field type DOUBLE is added to Tarantool. In the > > second patch, the DOUBLE type is added to SQL. > > > > https://github.com/tarantool/tarantool/issues/3812 > > https://github.com/tarantool/tarantool/tree/imeevma/gh-3812-add-double-type > > > > Mergen Imeev (2): > > box: introduce DOUBLE field type > > sql: introduce DOUBLE type > > > > extra/mkkeywordhash.c | 2 +- > > src/box/field_def.c | 28 ++- > > src/box/field_def.h | 1 + > > src/box/sql/expr.c | 6 +- > > src/box/sql/parse.y | 3 +- > > src/box/sql/sqlInt.h | 3 +- > > src/box/sql/vdbe.c | 4 + > > src/box/sql/vdbemem.c | 15 +- > > src/box/tuple_compare.cc | 24 ++ > > test/engine/insert.result | 151 +++++++++++ > > test/engine/insert.test.lua | 51 ++++ > > test/sql/gh-3888-values-blob-assert.result | 4 +- > > test/sql/misc.result | 4 +- > > test/sql/types.result | 390 ++++++++++++++++++++++++++++- > > test/sql/types.test.lua | 66 +++++ > > 15 files changed, 716 insertions(+), 36 deletions(-) > >
prev parent reply other threads:[~2019-12-27 12:37 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-21 16:03 imeevma 2019-12-21 16:03 ` [Tarantool-patches] [PATCH v1 1/2] box: introduce DOUBLE field type imeevma 2019-12-24 22:50 ` Nikita Pettik 2019-12-26 16:38 ` Mergen Imeev 2019-12-26 20:34 ` Nikita Pettik 2019-12-21 16:03 ` [Tarantool-patches] [PATCH v1 2/2] sql: introduce DOUBLE type imeevma 2019-12-24 22:50 ` Nikita Pettik 2019-12-26 16:42 ` Mergen Imeev 2019-12-26 20:37 ` Nikita Pettik 2019-12-23 19:16 ` [Tarantool-patches] [PATCH v1 0/2] Add DOUBLE type to SQL Vladislav Shpilevoy 2019-12-27 12:37 ` Nikita Pettik [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191227123724.GI18639@tarantool.org \ --to=korablev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1 0/2] Add DOUBLE type to SQL' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox