From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Maria Khaydich <maria.khaydich@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] box: make box.execute() immutable
Date: Thu, 26 Dec 2019 17:08:35 +0300 [thread overview]
Message-ID: <20191226140834.urhg7ude4b5zkep4@tkn_work_nb> (raw)
In-Reply-To: <1577201550.829136486@f483.i.mail.ru>
> function box.execute(...)
> - load_cfg()
> + --
> + -- Calling box.execute before explicitly configuring box led to
> + -- automatic box.cfg invocation nonetheless. Following explicit
> + -- attempts to configure box led to its reconfiguratin and as a
> + -- result - to an error when trying to use execute method again.
> + -- The check makes sure box.execute is an immutable function.
> + --
I would describe all this hell with registering lbox_execute as
box.execute, moving it to box_cfg_guard_whitelist, adding this
box.execute function, then replacing back with lbox_execute at
load_cfg().
This description would make clear why everything is fine if we just call
box.execute(), but extra flag is necessary if a user saved box.execute
before first box.execute() or box.cfg() call.
next prev parent reply other threads:[~2019-12-26 14:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 11:50 [Tarantool-patches] [PATCH] box.execute should be immutable function Maria
2019-11-14 16:51 ` Nikita Pettik
2019-12-17 14:39 ` Igor Munkin
2019-12-24 15:32 ` [Tarantool-patches] [PATCH] box: make box.execute() immutable Maria Khaydich
2019-12-25 1:30 ` Igor Munkin
2019-12-26 14:08 ` Alexander Turenko [this message]
2020-01-13 12:13 ` Maria Khaydich
2020-01-13 15:48 ` Igor Munkin
2020-01-18 10:56 ` Maria Khaydich
2020-02-20 17:51 ` Alexander Turenko
2020-02-20 21:15 ` Igor Munkin
2020-03-11 15:56 ` Maria Khaydich
2020-03-18 22:25 ` Igor Munkin
2020-05-02 14:52 ` Alexander Turenko
2020-05-12 16:16 ` Alexander Turenko
2020-03-11 15:57 ` [Tarantool-patches] [PATCH 1/2] box: make box.cfg idempotent function Maria Khaydich
2020-03-12 13:29 ` Konstantin Osipov
2020-03-12 19:25 ` Maria Khaydich
2020-03-12 20:00 ` Konstantin Osipov
2020-03-18 22:26 ` Igor Munkin
2020-03-19 7:19 ` Konstantin Osipov
2020-03-19 9:08 ` Igor Munkin
2020-03-19 10:06 ` Konstantin Osipov
2020-03-19 10:26 ` Igor Munkin
2020-05-06 11:17 ` Alexander Turenko
2020-05-06 11:49 ` Konstantin Osipov
2020-05-06 12:53 ` Alexander Turenko
2020-05-06 13:02 ` Konstantin Osipov
2020-05-06 13:13 ` Alexander Turenko
2020-03-18 22:26 ` Igor Munkin
2020-05-12 16:17 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191226140834.urhg7ude4b5zkep4@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=maria.khaydich@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] box: make box.execute() immutable' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox