From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v4] test: fix flaky socket test
Date: Thu, 26 Dec 2019 02:47:52 +0300 [thread overview]
Message-ID: <20191225234751.2j2zo44wivk7ptv5@tkn_work_nb> (raw)
In-Reply-To: <20191225012935.psngzpcp7zasjvr3@tkn_work_nb>
> [017] --- app/socket.result Wed Dec 25 01:18:29 2019
> [017] +++ app/socket.reject Wed Dec 25 01:19:30 2019
> [017] @@ -40,7 +40,7 @@
> [017] ...
> [017] test_run:cmd("push filter '(error: .builtin/.*[.]lua):[0-9]+' to '\\1'")
> [017] ---
> [017] -- true
> [017] +- Hello, world
>
> It seems we connected to some of our socket server rather then test-run.
> Looks like the same ipv4 / ipv6 problem.
>
> After the following patch for test-run I don't see it anymore (don't
> sure I made enough runs, however):
>
> diff --git a/lib/test_suite.py b/lib/test_suite.py
> index 84b99f4..0a137c3 100644
> --- a/lib/test_suite.py
> +++ b/lib/test_suite.py
> @@ -197,7 +197,7 @@ class TestSuite:
> def start_server(self, server):
> # create inspector daemon for cluster tests
> inspector = TarantoolInspector(
> - 'localhost', server.inspector_port
> + '127.0.0.1', server.inspector_port
> )
> inspector.start()
> # fixme: remove this string if we fix all legacy tests
> diff --git a/test_run.lua b/test_run.lua
> index e37b559..fc1b833 100644
> --- a/test_run.lua
> +++ b/test_run.lua
> @@ -458,7 +458,7 @@ local inspector_methods = {
> local function inspector_new(host, port)
> local inspector = {}
>
> - inspector.host = host or 'localhost'
> + inspector.host = host or '127.0.0.1'
> inspector.port = port or tonumber(os.getenv('INSPECTOR'))
> if inspector.port == nil then
> error('Inspector not started')
Patch: https://github.com/tarantool/test-run/pull/197
WBR, Alexander Turenko.
next prev parent reply other threads:[~2019-12-25 23:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 20:48 Ilya Kosarev
2019-12-25 1:29 ` Alexander Turenko
2019-12-25 21:06 ` Ilya Kosarev
2019-12-25 23:47 ` Alexander Turenko [this message]
2019-12-24 12:58 Ilya Kosarev
2019-12-24 16:33 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191225234751.2j2zo44wivk7ptv5@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4] test: fix flaky socket test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox