From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] box/console: Handle multireturn in lua mode
Date: Wed, 25 Dec 2019 16:11:28 +0300 [thread overview]
Message-ID: <20191225131128.GB2463@uranus> (raw)
In-Reply-To: <20191225123606.jnufsyn4exvryn2q@tkn_work_nb>
On Wed, Dec 25, 2019 at 03:36:07PM +0300, Alexander Turenko wrote:
> Looks good in general and works correct even with nils at the end.
>
> We however should add a test case for this, otherwise sooner or later
> we'll unable to make changes w/o fear to broke something. I propose to
> add a case with nils at the end as well as simple 1, 2, 3 multireturn.
>
> I put several nits below. Some of them are pointed by our [Lua Style
> Guide][1], another ones are what I see across other parts of our
> codebase. My intention here is to keep the style more or less consistent
> and so make it more comfortable to work with the code (hope not only for
> me, otherwise it is not productive).
>
> [1]: https://www.tarantool.io/en/doc/1.10/dev_guide/lua_style_guide/
Thanks! I'll update and resend together with a testcase.
prev parent reply other threads:[~2019-12-25 13:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 17:45 Cyrill Gorcunov
2019-12-25 12:36 ` Alexander Turenko
2019-12-25 13:11 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191225131128.GB2463@uranus \
--to=gorcunov@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] box/console: Handle multireturn in lua mode' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox