From: Nikita Pettik <korablev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] sql: drop only generated sequence in DROP TABLE
Date: Wed, 25 Dec 2019 02:19:43 +0300 [thread overview]
Message-ID: <20191224231943.GA18639@tarantool.org> (raw)
In-Reply-To: <400814c8-b019-11d8-1cc6-1b9a6ccbdc22@tarantool.org>
On 24 Dec 17:26, Vladislav Shpilevoy wrote:
> Thanks for the review!
>
> On 24/12/2019 02:23, Nikita Pettik wrote:
> > On 18 Dec 14:00, Chris Sosnin wrote:
> >> create mode 100644 test/sql/autoincrement.result
> >> create mode 100644 test/sql/autoincrement.test.lua
> >>
> >> diff --git a/test/sql/autoincrement.test.lua b/test/sql/autoincrement.test.lua
> >
> > Patch itself is LGTM (as obvious). But I am not a big fan of placing each
> > test in separate file (at least when there's no specific issue for that).
>
> As you know, me neither. I added this new file to put here all
> autoincrement stuff now and in future. We have sql-tap/autoinc,
> but sql-tap tests are really hard to write and fix.
It's hard in comparison with sql/ suite. But in general, sql tap tests
are quite simple and easy to write (IMHO).
> > Moreover, in commit message it is said that this patch is follow-up to
> > #4546, so could you move this test to gh-4546-sql-drop-grants.test.lua ?
>
> 4546 was about table grants. The test in autoincrement file about a
> different bug - drop of sequence. It is kinda related to 4546 in that
> sequence grants also should be dropped, if their sequence is deleted.
Ok, then I will simply remove 'follow-up' remark and push it to master.
prev parent reply other threads:[~2019-12-24 23:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 12:53 [Tarantool-patches] [PATCH] sql: remove grants associated with the table Chris Sosnin
2019-12-07 10:29 ` Chris Sosnin
2019-12-10 23:45 ` Vladislav Shpilevoy
2019-12-11 9:50 ` Chris Sosnin
2019-12-17 23:13 ` Vladislav Shpilevoy
2019-12-17 23:13 ` Vladislav Shpilevoy
2019-12-18 11:00 ` [Tarantool-patches] [PATCH 0/2] sql: revoke table privileges on drop Chris Sosnin
2019-12-18 11:00 ` [Tarantool-patches] [PATCH 1/2] sql: remove grants associated with the table Chris Sosnin
2019-12-24 1:37 ` Nikita Pettik
2019-12-24 16:47 ` Vladislav Shpilevoy
2019-12-18 11:00 ` [Tarantool-patches] [PATCH 2/2] sql: drop only generated sequence in DROP TABLE Chris Sosnin
2019-12-24 1:23 ` Nikita Pettik
2019-12-24 16:26 ` Vladislav Shpilevoy
2019-12-24 23:19 ` Nikita Pettik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191224231943.GA18639@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] sql: drop only generated sequence in DROP TABLE' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox