Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Leonid Vasiliev <lvasiliev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] Add a cancellation guard to cpipe flush callback
Date: Tue, 24 Dec 2019 18:33:08 +0300	[thread overview]
Message-ID: <20191224153308.GD30240@atlas> (raw)
In-Reply-To: <7b4e53cf-f2a8-1dca-4eb1-0c315f0b8932@tarantool.org>

* Leonid Vasiliev <lvasiliev@tarantool.org> [19/12/24 18:30]:
> 
> Other alternatives (which I can come up with) add possible races or
> cancellation points.
> We must cancel the thread before cancellation point in ev_async_send
> (ev_async_send(endpoint->consumer, &endpoint->async);) and as close as
> possible to it for to reproduce a behavior from
> https://github.com/tarantool/tarantool/issues/4127 .

I think if you add some stress component to test then it'll hit
the right timing once in a while without violating encapsulation.

But it's great you do have a way to reproduce at least...

-- 
Konstantin Osipov, Moscow, Russia

      reply	other threads:[~2019-12-24 15:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03 16:33 Leonid Vasiliev
2019-12-03 18:02 ` Konstantin Osipov
2019-12-05  7:22   ` Leonid Vasiliev
2019-12-05  7:27     ` Konstantin Osipov
2019-12-23 12:44       ` Leonid Vasiliev
2019-12-23 12:55         ` Konstantin Osipov
2019-12-24 15:27           ` Leonid Vasiliev
2019-12-24 15:33             ` Konstantin Osipov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191224153308.GD30240@atlas \
    --to=kostja.osipov@gmail.com \
    --cc=lvasiliev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] Add a cancellation guard to cpipe flush callback' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox