Re: [Tarantool-patches] [PATCH v3 08/20] port: increase padding of struct port

[Sergey Ostanevich <sergos@tarantool.org>]

Hi!

Thanks for the patch!

See my comment below.

Sergos


On 20 Dec 15:47, Nikita Pettik wrote:
> We are going to extend context of struct port_sql. One already inherits
> struct port_tuple, which makes it size barely fits into 48 bytes of
> padding of basic structure (struct port). Hence, let's increase padding
> a bit to be able to add at least one more member to struct port_sql.
> ---
>  src/lib/core/port.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lib/core/port.h b/src/lib/core/port.h
> index d61342287..bfdfa4656 100644
> --- a/src/lib/core/port.h
> +++ b/src/lib/core/port.h
> @@ -122,7 +122,7 @@ struct port {
>  	 * Implementation dependent content. Needed to declare
>  	 * an abstract port instance on stack.
>  	 */
> -	char pad[48];
> +	char pad[52];

The port_sql struct is containing the port_tuple and a 3 extra fields. I
agree that port_typle size is 48 bytes, but how do you plat to fit 3
fields in 4 extra bytes?

>  };
>  
>  /** Is not inlined just to be exported. */
> -- 
> 2.15.1
>