From: Nikita Pettik <korablev@tarantool.org>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 6/6] sql: extend result set with alias
Date: Tue, 24 Dec 2019 03:27:33 +0300 [thread overview]
Message-ID: <20191224002733.GA41539@tarantool.org> (raw)
In-Reply-To: <20191219151758.GD28206@tarantool.org>
On 19 Dec 18:17, Sergey Ostanevich wrote:
> Hi!
>
> In the current branch I see the following opportunity:
Thanks, Vlad suggested the same refactoring, I've applied it.
> diff --git a/src/box/sql/select.c b/src/box/sql/select.c
> index c1770e7b4..3fc8b2f96 100644
> --- a/src/box/sql/select.c
> +++ b/src/box/sql/select.c
> @@ -1828,12 +1828,10 @@ generate_column_metadata(struct Parse *pParse, struct SrcList *pTabList,
> const char *name = NULL;
> if (pEList->a[i].zName != NULL) {
> if (is_full_meta) {
> - const char *alias = NULL;
> + const char *alias = pEList->a[i].zName;
> if (pEList->a[i].zSpan != NULL) {
> - alias = pEList->a[i].zName;
> name = pEList->a[i].zSpan;
> } else {
> - alias = pEList->a[i].zName;
> name = pEList->a[i].zName;
> }
> vdbe_metadata_set_col_alias(v, i, alias);
> @@ -1868,12 +1866,10 @@ generate_column_metadata(struct Parse *pParse, struct SrcList *pTabList,
> const char *z = NULL;
> if (pEList->a[i].zName != NULL) {
> if (is_full_meta ) {
> - const char *alias = NULL;
> + const char *alias = pEList->a[i].zName;
> if (pEList->a[i].zSpan != NULL) {
> - alias = pEList->a[i].zName;
> z = pEList->a[i].zSpan;
> } else {
> - alias = pEList->a[i].zName;
> z = pEList->a[i].zName;
> }
> vdbe_metadata_set_col_alias(v, i, alias);
>
>
>
> Although, I see you have unfinished discussion on whether name should be alias
> or vice versa - I won't interrupt you.
>
> Regards,
> Sergos
>
next prev parent reply other threads:[~2019-12-24 0:27 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 12:15 [Tarantool-patches] [PATCH 0/6] sql: extend response metadata Nikita Pettik
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 1/6] sql: refactor resulting set metadata Nikita Pettik
2019-11-28 22:41 ` Vladislav Shpilevoy
2019-12-05 11:39 ` Nikita Pettik
2019-12-05 23:58 ` Vladislav Shpilevoy
2019-12-06 12:48 ` Nikita Pettik
2019-12-17 13:23 ` Sergey Ostanevich
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 2/6] sql: fix possible null dereference in sql_expr_coll() Nikita Pettik
2019-11-28 22:42 ` Vladislav Shpilevoy
2019-12-05 11:40 ` Nikita Pettik
2019-12-05 23:59 ` Vladislav Shpilevoy
2019-12-06 12:48 ` Nikita Pettik
2019-12-17 13:30 ` Sergey Ostanevich
2019-12-17 14:44 ` Nikita Pettik
2019-12-17 19:53 ` Nikita Pettik
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 3/6] sql: extend result set with collation Nikita Pettik
2019-11-28 22:41 ` Vladislav Shpilevoy
2019-12-05 11:50 ` Nikita Pettik
2019-12-18 11:08 ` Sergey Ostanevich
2019-12-24 0:44 ` Nikita Pettik
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 4/6] sql: extend result set with nullability Nikita Pettik
2019-11-28 22:41 ` Vladislav Shpilevoy
2019-12-05 11:50 ` Nikita Pettik
2019-12-06 0:00 ` Vladislav Shpilevoy
2019-12-06 12:49 ` Nikita Pettik
2019-12-18 13:31 ` Sergey Ostanevich
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 5/6] sql: extend result set with autoincrement Nikita Pettik
2019-11-28 22:41 ` Vladislav Shpilevoy
2019-12-05 11:51 ` Nikita Pettik
2019-12-18 15:17 ` Sergey Ostanevich
2019-12-24 0:47 ` Nikita Pettik
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 6/6] sql: extend result set with alias Nikita Pettik
2019-11-28 22:41 ` Vladislav Shpilevoy
2019-12-05 11:51 ` Nikita Pettik
2019-12-06 0:02 ` Vladislav Shpilevoy
2019-12-06 12:50 ` Nikita Pettik
2019-12-06 21:52 ` Vladislav Shpilevoy
2019-12-19 15:17 ` Sergey Ostanevich
2019-12-24 0:27 ` Nikita Pettik [this message]
2019-11-28 22:55 ` [Tarantool-patches] [PATCH 0/6] sql: extend response metadata Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191224002733.GA41539@tarantool.org \
--to=korablev@tarantool.org \
--cc=sergos@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 6/6] sql: extend result set with alias' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox