From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 2/4] popen: Introduce a backend engine
Date: Fri, 20 Dec 2019 15:04:46 +0300 [thread overview]
Message-ID: <20191220120446.GA9637@atlas> (raw)
In-Reply-To: <20191220115257.GA10179@uranus>
* Cyrill Gorcunov <gorcunov@gmail.com> [19/12/20 14:56]:
> > > +static void
> > > +handle_free(struct popen_handle *handle)
> > > +{
> > > + say_debug("popen: handle %p free %p", handle);
> > > + free(handle);
> > > +}
> >
> > I don't understand who owns char *command and why
> > it's not freed here. Could you please clarify?
>
> Look, the command is compiled from argv array into
> a single string dynamically allocated. The handle
> just carries a reference to it. If you think it will
> be more suitable to allocate command together with
> handle itself in one place then sure I'll update.
Where is it freed?
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-12-20 12:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 12:54 [Tarantool-patches] [PATCH v6 0/4] popen: Add ability to run external process Cyrill Gorcunov
2019-12-17 12:54 ` [Tarantool-patches] [PATCH v6 1/4] coio: Export helpers and provide coio_read_fd_timeout Cyrill Gorcunov
2019-12-20 7:48 ` Konstantin Osipov
2019-12-20 14:50 ` Cyrill Gorcunov
2019-12-17 12:54 ` [Tarantool-patches] [PATCH v6 2/4] popen: Introduce a backend engine Cyrill Gorcunov
2019-12-20 8:11 ` Konstantin Osipov
2019-12-20 11:52 ` Cyrill Gorcunov
2019-12-20 12:04 ` Konstantin Osipov [this message]
2019-12-20 12:10 ` Cyrill Gorcunov
2019-12-20 12:11 ` Alexander Turenko
2019-12-26 7:14 ` Konstantin Osipov
2019-12-26 7:19 ` Cyrill Gorcunov
2020-01-09 11:23 ` Cyrill Gorcunov
2019-12-17 12:54 ` [Tarantool-patches] [PATCH v6 3/4] popen/lua: Add popen module Cyrill Gorcunov
2019-12-20 15:41 ` Maxim Melentiev
2019-12-17 12:54 ` [Tarantool-patches] [PATCH v6 4/4] popen/test: Add base test cases Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220120446.GA9637@atlas \
--to=kostja.osipov@gmail.com \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v6 2/4] popen: Introduce a backend engine' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox