From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3] memtx: fix out of memory handling for rtree
Date: Thu, 19 Dec 2019 18:09:07 +0300 [thread overview]
Message-ID: <20191219150907.GD30445@atlas> (raw)
In-Reply-To: <4350dbf5-6fcd-634b-fc28-6eb2df288ca0@tarantool.org>
* Olga Arkhangelskaia <arkholga@tarantool.org> [19/12/19 17:45]:
> I can't agree - everything that has memtx_ should be in memtx, because
> generic is used by vinyl, and sysview.
Neither vinyl nor sysview build secondary indexes using
build_next. This name - generic_* is a conversion mistake
introduced during C++ -> C transition, it should be
memtx_default_build_next. The generic build next should
assert(false), it should be never called. If, for whatever reason,
it's called, you still can split have a generic_memtx_build_next
> And the only way I see do it generic - is to use index_reserve? Did you mean
> index_reserve, that has memtx_index_extent_reserve( inside?
>
> In this case it is not shorter.
>
--
Konstantin Osipov, Moscow, Russia
prev parent reply other threads:[~2019-12-19 15:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 13:41 Olga Arkhangelskaia
2019-12-19 14:14 ` Konstantin Osipov
2019-12-19 14:45 ` Olga Arkhangelskaia
2019-12-19 15:09 ` Konstantin Osipov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219150907.GD30445@atlas \
--to=kostja.osipov@gmail.com \
--cc=arkholga@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3] memtx: fix out of memory handling for rtree' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox