Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin <imun@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 0/5] Improved the static build based on Dockerfile
Date: Wed, 18 Dec 2019 19:01:47 +0300	[thread overview]
Message-ID: <20191218160147.GW1214@tarantool.org> (raw)
In-Reply-To: <cover.1575976611.git.avtikhon@tarantool.org>

Sasha,

Thanks for the patchset, I left several comments per patch, however in
the first one I wrote a general one, but I think it's convenient to left
it here too.

I guess it's preferable to have a sole 'build:' tag for any patch
related to the build system. Feel free to ignore and proceed if
Sasha Tu. (he's already CCed as a second reviewer) has no remarks to the
subj.

On 10.12.19, Alexander V. Tikhonov wrote:
> Made the following changes at Dockerfile for static build:
>      - changed 'wget' tool use to 'curl -O -L' to avoid of '500' HTTP
>        error respond from download servers
>      - changed the link from sourceforge to github to download
>        the icu4c sources, as suggested on icu4c web site
>      - added 'build' directory removement to avoid of old configuration
>        at build/curl which is used for curl building
>      - removed LD_LIBRARY_PATH environment from curl build, due to the
>        path is empty in real and is not needed
>      - added '-j' option to make tool calls for all builds to speed it up
>        in 4 times
>      - set Dockerfile WORKDIR from the very start of Tarantool sources
>        builds to make the Dockerfile code more readable and removed all
>        duplicating calls to Tarantool sources directory changes.
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/dockerfile-static-build-full-ci
> Issue: -
> 
> Alexander V. Tikhonov (5):
>   static build: speedup build
>   static build: remove unneeded LD_LIBRARY_PATH
>   static build: cleanup Dockerfile
>   static build: added build subdirectory cleanup
>   static build: resolve issues with sourceforge.net
> 
>  Dockerfile.staticbuild | 37 +++++++++++++++++--------------------
>  1 file changed, 17 insertions(+), 20 deletions(-)
> 
> -- 
> 2.17.1
> 

-- 
Best regards,
IM

  parent reply	other threads:[~2019-12-18 16:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10 11:21 Alexander V. Tikhonov
2019-12-10 11:21 ` [Tarantool-patches] [PATCH v2 1/5] static build: speedup build Alexander V. Tikhonov
2019-12-18 12:21   ` Igor Munkin
2019-12-19  9:26     ` Alexander Tikhonov
2020-04-01  9:56       ` Sergey Bronnikov
2019-12-10 11:21 ` [Tarantool-patches] [PATCH v2 2/5] static build: remove unneeded LD_LIBRARY_PATH Alexander V. Tikhonov
2019-12-18 12:49   ` Igor Munkin
2019-12-19  9:27     ` Alexander Tikhonov
2020-04-01  9:57       ` Sergey Bronnikov
2019-12-10 11:21 ` [Tarantool-patches] [PATCH v2 3/5] static build: cleanup Dockerfile Alexander V. Tikhonov
2019-12-18 15:01   ` Igor Munkin
2019-12-19  9:28     ` Alexander Tikhonov
2020-04-01  9:54       ` Sergey Bronnikov
2019-12-10 11:21 ` [Tarantool-patches] [PATCH v2 4/5] static build: added build subdirectory cleanup Alexander V. Tikhonov
2019-12-18 15:34   ` Igor Munkin
2019-12-19  9:28     ` Alexander Tikhonov
2020-04-01  9:54       ` Sergey Bronnikov
2019-12-10 11:21 ` [Tarantool-patches] [PATCH v2 5/5] static build: resolve issues with sourceforge.net Alexander V. Tikhonov
2019-12-18 15:55   ` Igor Munkin
2019-12-19  9:34     ` Alexander Tikhonov
2020-04-01  9:53       ` Sergey Bronnikov
2020-04-01 10:18         ` Alexander Tikhonov
2019-12-18 16:01 ` Igor Munkin [this message]
2019-12-19  9:29   ` [Tarantool-patches] [PATCH v2 0/5] Improved the static build based on Dockerfile Alexander Tikhonov
2020-04-02 10:35 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191218160147.GW1214@tarantool.org \
    --to=imun@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 0/5] Improved the static build based on Dockerfile' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox