From: Igor Munkin <imun@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 5/5] static build: resolve issues with sourceforge.net
Date: Wed, 18 Dec 2019 18:55:31 +0300 [thread overview]
Message-ID: <20191218155531.GV1214@tarantool.org> (raw)
In-Reply-To: <6134685e3cd58b3ee404f9eaeb7e02eb3553144d.1575976611.git.avtikhon@tarantool.org>
Sasha,
Thanks for the patch! I see there was an issue with upstream, therefore
you moved the link to github release. However I still don't get your
motivation for replacing wget with curl (and as I see in the v1 review
neither does Sasha Tu.). Could you please provide a bit more extended
rationale for such substitution?
On 10.12.19, Alexander V. Tikhonov wrote:
> Found that wget may fail on downloading the file from flaky
> available servers with 500 HTTP error, like it was seen on
> icu4c sources downloading, please check the issue:
> https://sourceforge.net/p/forge/site-support/20071/
>
> Found that curl successfully downloads needed files even in
> such situations. Decided to use curl instead of wget tool
> to avoid of such errors feather.
>
> Also found that sourceforge site too often has issues and
> responds with 500 HTTP error. Decided to use the link from
> github instead of sourceforge to download the icu4c sources,
> as suggested on icu4c web site.
> ---
> Dockerfile.staticbuild | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> index 0424179a2..49895a4de 100644
> --- a/Dockerfile.staticbuild
> +++ b/Dockerfile.staticbuild
> @@ -48,7 +48,7 @@ RUN set -x && \
>
> RUN set -x && \
> cd / && \
> - wget http://download.icu-project.org/files/icu4c/62.1/icu4c-62_1-src.tgz && \
> + curl -O -L https://github.com/unicode-org/icu/releases/download/release-62-1/icu4c-62_1-src.tgz && \
> tar -xvf icu4c-62_1-src.tgz && \
> cd icu/source && \
> ./configure --with-data-packaging=static --enable-static --enable-shared && \
> --
> 2.17.1
>
--
Best regards,
IM
next prev parent reply other threads:[~2019-12-18 15:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 11:21 [Tarantool-patches] [PATCH v2 0/5] Improved the static build based on Dockerfile Alexander V. Tikhonov
2019-12-10 11:21 ` [Tarantool-patches] [PATCH v2 1/5] static build: speedup build Alexander V. Tikhonov
2019-12-18 12:21 ` Igor Munkin
2019-12-19 9:26 ` Alexander Tikhonov
2020-04-01 9:56 ` Sergey Bronnikov
2019-12-10 11:21 ` [Tarantool-patches] [PATCH v2 2/5] static build: remove unneeded LD_LIBRARY_PATH Alexander V. Tikhonov
2019-12-18 12:49 ` Igor Munkin
2019-12-19 9:27 ` Alexander Tikhonov
2020-04-01 9:57 ` Sergey Bronnikov
2019-12-10 11:21 ` [Tarantool-patches] [PATCH v2 3/5] static build: cleanup Dockerfile Alexander V. Tikhonov
2019-12-18 15:01 ` Igor Munkin
2019-12-19 9:28 ` Alexander Tikhonov
2020-04-01 9:54 ` Sergey Bronnikov
2019-12-10 11:21 ` [Tarantool-patches] [PATCH v2 4/5] static build: added build subdirectory cleanup Alexander V. Tikhonov
2019-12-18 15:34 ` Igor Munkin
2019-12-19 9:28 ` Alexander Tikhonov
2020-04-01 9:54 ` Sergey Bronnikov
2019-12-10 11:21 ` [Tarantool-patches] [PATCH v2 5/5] static build: resolve issues with sourceforge.net Alexander V. Tikhonov
2019-12-18 15:55 ` Igor Munkin [this message]
2019-12-19 9:34 ` Alexander Tikhonov
2020-04-01 9:53 ` Sergey Bronnikov
2020-04-01 10:18 ` Alexander Tikhonov
2019-12-18 16:01 ` [Tarantool-patches] [PATCH v2 0/5] Improved the static build based on Dockerfile Igor Munkin
2019-12-19 9:29 ` Alexander Tikhonov
2020-04-02 10:35 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218155531.GV1214@tarantool.org \
--to=imun@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 5/5] static build: resolve issues with sourceforge.net' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox