Re: [Tarantool-patches] [PATCH v2 4/5] static build: added build subdirectory cleanup

[Igor Munkin <imun@tarantool.org>]

Sasha,

Thanks for the patch! I left two comments below, please consider them.

On 10.12.19, Alexander V. Tikhonov wrote:
> Added 'build' directory removement to avoid of old configuration
> at build/curl which is used for curl building.

The commit message looks a bit complex. I rewrote it a little, as the
following:
| Added the command for 'build' directory cleanup. It purges all
| artefacts produced for curl build, including the old configuration in
| build/curl.
Feel free to adjust the commit message in your own way.

> ---
>  Dockerfile.staticbuild | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> index 66342fa4e..0424179a2 100644
> --- a/Dockerfile.staticbuild
> +++ b/Dockerfile.staticbuild
> @@ -72,7 +72,8 @@ RUN set -x && \
>  
>  RUN set -x && \
>      find . -name 'CMakeFiles' -type d -exec rm -rf {} + && \
> -    find . -name 'CMakeCache.txt' -type f -delete
> +    find . -name 'CMakeCache.txt' -type f -delete && \

Please drop a comment about the build directory source, since it's not
created (or even mentioned) within Docker file.

> +    rm -rf build
>  
>  RUN pip install -r /tarantool/test-run/requirements.txt
>  
> -- 
> 2.17.1
> 

-- 
Best regards,
IM