From: Igor Munkin <imun@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/5] static build: speedup build
Date: Wed, 18 Dec 2019 15:21:27 +0300 [thread overview]
Message-ID: <20191218122127.GR1214@tarantool.org> (raw)
In-Reply-To: <456b2851ac23fa58fd1498d20888e72ce67d63f7.1575976611.git.avtikhon@tarantool.org>
Sasha,
Thanks, the changes LGTM except the one minor comment: I guess it's
preferable to have a sole 'build:' tag for any patch related to the
build system. Feel free to ignore and proceed if Sasha Tu. (he's already
CCed as a second reviewer) has no remarks to the subj.
On 10.12.19, Alexander V. Tikhonov wrote:
> Added '-j' option to make for tools buildings, it decreased build time in 4 times.
> ---
> Dockerfile.staticbuild | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> index d63c18bd1..8da8ae304 100644
> --- a/Dockerfile.staticbuild
> +++ b/Dockerfile.staticbuild
> @@ -44,7 +44,7 @@ RUN set -x && \
> tar -xvf openssl-1.1.0h.tar.gz && \
> cd openssl-1.1.0h && \
> ./config --libdir=lib && \
> - make && make install
> + make -j && make install
>
> RUN set -x && \
> cd / && \
> @@ -52,7 +52,7 @@ RUN set -x && \
> tar -xvf icu4c-62_1-src.tgz && \
> cd icu/source && \
> ./configure --with-data-packaging=static --enable-static --enable-shared && \
> - make && make install
> + make -j && make install
>
> RUN set -x && \
> cd / && \
> @@ -60,7 +60,7 @@ RUN set -x && \
> tar -xvf libunwind-1.3-rc1.tar.gz && \
> cd libunwind-1.3-rc1 && \
> ./configure --enable-static --enable-shared && \
> - make && make install
> + make -j && make install
>
> COPY . /tarantool
>
> --
> 2.17.1
>
--
Best regards,
IM
next prev parent reply other threads:[~2019-12-18 12:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 11:21 [Tarantool-patches] [PATCH v2 0/5] Improved the static build based on Dockerfile Alexander V. Tikhonov
2019-12-10 11:21 ` [Tarantool-patches] [PATCH v2 1/5] static build: speedup build Alexander V. Tikhonov
2019-12-18 12:21 ` Igor Munkin [this message]
2019-12-19 9:26 ` Alexander Tikhonov
2020-04-01 9:56 ` Sergey Bronnikov
2019-12-10 11:21 ` [Tarantool-patches] [PATCH v2 2/5] static build: remove unneeded LD_LIBRARY_PATH Alexander V. Tikhonov
2019-12-18 12:49 ` Igor Munkin
2019-12-19 9:27 ` Alexander Tikhonov
2020-04-01 9:57 ` Sergey Bronnikov
2019-12-10 11:21 ` [Tarantool-patches] [PATCH v2 3/5] static build: cleanup Dockerfile Alexander V. Tikhonov
2019-12-18 15:01 ` Igor Munkin
2019-12-19 9:28 ` Alexander Tikhonov
2020-04-01 9:54 ` Sergey Bronnikov
2019-12-10 11:21 ` [Tarantool-patches] [PATCH v2 4/5] static build: added build subdirectory cleanup Alexander V. Tikhonov
2019-12-18 15:34 ` Igor Munkin
2019-12-19 9:28 ` Alexander Tikhonov
2020-04-01 9:54 ` Sergey Bronnikov
2019-12-10 11:21 ` [Tarantool-patches] [PATCH v2 5/5] static build: resolve issues with sourceforge.net Alexander V. Tikhonov
2019-12-18 15:55 ` Igor Munkin
2019-12-19 9:34 ` Alexander Tikhonov
2020-04-01 9:53 ` Sergey Bronnikov
2020-04-01 10:18 ` Alexander Tikhonov
2019-12-18 16:01 ` [Tarantool-patches] [PATCH v2 0/5] Improved the static build based on Dockerfile Igor Munkin
2019-12-19 9:29 ` Alexander Tikhonov
2020-04-02 10:35 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218122127.GR1214@tarantool.org \
--to=imun@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/5] static build: speedup build' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox