From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Leonid Vasiliev <lvasiliev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] Fix queue test preparing
Date: Wed, 18 Dec 2019 05:02:07 +0300 [thread overview]
Message-ID: <20191218020206.wuhr7fb3pc3qikex@tkn_work_nb> (raw)
In-Reply-To: <eae1afc1-8ce0-cbfb-8c8e-88562f64ba05@tarantool.org>
Expanded the commit message:
| travis-ci: handle packagecloud's HTTP redirects
|
| Added curl options:
|
| * -L (--location) to follow Location header value from 3XX responses,
| because packagecloud.io redirects a GPG key request to a CDN.
| * -s (--silent) to don't show a progress meter.
| * -f (--fail) to fail the command at non 2XX HTTP responses. It'll fail
| `curl | <...>` command pipeline, since `set -o pipefail` is now
| enabled.
|
| Aside of that, fail test.sh script (and so a CI job) if something inside
| the script fails (`set -e`) and catch mistakes from using uninitialized
| bash variables (`set -u`) inside the script.
And pushed.
Thanks!
WBR, Alexander Turenko.
On Fri, Dec 06, 2019 at 10:18:55PM +0300, Leonid Vasiliev wrote:
> https://github.com/tarantool/queue/tree/lvasiliev/gh-noticket-fix-redirect-case
>
> On 12/6/19 8:36 PM, Leonid Vasiliev wrote:
> > Add redirect procesing and check of a commands exit code.
> >
> > ---
> > test.sh | 8 +++++---
> > 1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/test.sh b/test.sh
> > index 3fca125..32f7567 100755
> > --- a/test.sh
> > +++ b/test.sh
> > @@ -1,15 +1,17 @@
> > #!/bin/bash
> > +set -euo pipefail
> > +
> > VERSION=${VERSION:-2_2}
> > -curl https://packagecloud.io/tarantool/${VERSION}/gpgkey | sudo apt-key add -
> > +curl -sfL https://packagecloud.io/tarantool/${VERSION}/gpgkey | sudo apt-key add -
> > release=`lsb_release -c -s`
> > sudo apt-get install -y apt-transport-https
> > sudo tee /etc/apt/sources.list.d/tarantool_${VERSION}.list <<- EOF
> > -deb https://packagecloud.io/tarantool/${VERSION}/ubuntu/ $release main
> > -deb-src https://packagecloud.io/tarantool/${VERSION}/ubuntu/ $release main
> > +deb https://packagecloud.io/tarantool/${VERSION}/ubuntu/ ${release} main
> > +deb-src https://packagecloud.io/tarantool/${VERSION}/ubuntu/ ${release} main
> > EOF
> > sudo apt-get update > /dev/null
> >
prev parent reply other threads:[~2019-12-18 2:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 17:36 Leonid Vasiliev
2019-12-06 19:18 ` Leonid Vasiliev
2019-12-18 2:02 ` Alexander Turenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218020206.wuhr7fb3pc3qikex@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=lvasiliev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] Fix queue test preparing' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox