From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/1] lua/serializer: encode Lua number -2^63 as integer
Date: Wed, 18 Dec 2019 04:34:49 +0300 [thread overview]
Message-ID: <20191218013448.cwmg7cbbbfdm6fxr@tkn_work_nb> (raw)
In-Reply-To: <0e3de775c20f0e5776301a5b39fa1e22e0e8bdb7.1576060409.git.imeevma@gmail.com>
Thanks!
LGTM.
Igor, can you do second review?
WBR, Alexander Turenko.
On Wed, Dec 11, 2019 at 01:49:02PM +0300, imeevma@tarantool.org wrote:
> Hi! Thank you for review! My answers and new patch below.
>
> https://github.com/tarantool/tarantool/issues/4672
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4672-fix-min-integer-in-lua
next prev parent reply other threads:[~2019-12-18 1:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 10:49 imeevma
2019-12-18 1:34 ` Alexander Turenko [this message]
2019-12-18 21:42 ` Igor Munkin
2019-12-19 12:34 ` Mergen Imeev
2019-12-19 11:06 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218013448.cwmg7cbbbfdm6fxr@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/1] lua/serializer: encode Lua number -2^63 as integer' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox