From: HustonMmmavr <huston.mavr@gmail.com>
To: tarantool-patches@dev.tarantool.org, imun@tarantool.org
Subject: [Tarantool-patches] [PATCH] fio: fix race condition in mktree
Date: Tue, 17 Dec 2019 18:52:23 +0300 [thread overview]
Message-ID: <20191217155223.13153-1-huston.mavr@gmail.com> (raw)
This patch fixes a bug that occours when two instances calls
fio.mktree for the same directory in parallel.
Closes #4660
---
branch: https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-4660-fix-fio-mktree-race
issue: https://github.com/tarantool/tarantool/issues/4660
src/lua/fio.lua | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lua/fio.lua b/src/lua/fio.lua
index cb224f3d0..c9aeac951 100644
--- a/src/lua/fio.lua
+++ b/src/lua/fio.lua
@@ -364,7 +364,7 @@ fio.mktree = function(path, mode)
local stat = fio.stat(current_dir)
if stat == nil then
local st, err = fio.mkdir(current_dir, mode)
- if err ~= nil then
+ if err ~= nil and not fio.path.is_dir(current_dir) then
return false, string.format("Error creating directory %s: %s",
current_dir, tostring(err))
end
--
2.23.0
next reply other threads:[~2019-12-17 15:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 15:52 HustonMmmavr [this message]
2020-01-10 11:33 ` Igor Munkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217155223.13153-1-huston.mavr@gmail.com \
--to=huston.mavr@gmail.com \
--cc=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] fio: fix race condition in mktree' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox