From: Kirill Yukhin <kyukhin@tarantool.org>
To: Chris Sosnin <k.sosnin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] build: GCC warning on strncpy
Date: Mon, 16 Dec 2019 16:40:41 +0300 [thread overview]
Message-ID: <20191216134041.wgijajmy4wemmzy4@tarantool.org> (raw)
In-Reply-To: <20191127213037.94837-2-k.sosnin@tarantool.org>
Hello,
On 28 ноя 00:30, Chris Sosnin wrote:
> Thank you for the review!
> See second version below.
> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4515-build-warning
> issue: https://github.com/tarantool/tarantool/issues/4515
>
> As long as we are sure, that strlen(sd_unix_path) < sizeof(sa.sun_path)
> we can assume that there is always enough space and the path will be
> null-terminated. Thus, copy 1 byte less to get rid of the warning.
>
> Closes #4515
I've checked your patch into 1.10, 2.2 and master.
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2019-12-16 13:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 21:30 [Tarantool-patches] [PATCH v2] box: frommap() bug fix Chris Sosnin
2019-11-27 21:30 ` [Tarantool-patches] [PATCH v2] build: GCC warning on strncpy Chris Sosnin
2019-11-27 23:40 ` Vladislav Shpilevoy
2019-12-16 13:40 ` Kirill Yukhin [this message]
2019-11-27 23:40 ` [Tarantool-patches] [PATCH v2] box: frommap() bug fix Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216134041.wgijajmy4wemmzy4@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=k.sosnin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] build: GCC warning on strncpy' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox