From: Nikita Pettik <korablev@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 09/16] sql: resurrect sql_bind_parameter_name()
Date: Fri, 13 Dec 2019 16:55:55 +0300 [thread overview]
Message-ID: <20191213135555.GA80915@tarantool.org> (raw)
In-Reply-To: <20191204115517.GK6592@atlas>
On 04 Dec 14:55, Konstantin Osipov wrote:
> * Nikita Pettik <korablev@tarantool.org> [19/11/21 10:00]:
> > +/**
> > + * Return the name of a wildcard parameter. Return NULL if the index
> > + * is out of range or if the wildcard is unnamed.
> > + */
>
> Please document the valid range of the index (0-based I assume)
> > +const char *
> > +sql_bind_parameter_name(sql_stmt *stmt, int i);
> >
Fixed:
diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h
index e5092b7a4..a5c564b8a 100644
--- a/src/box/sql/sqlInt.h
+++ b/src/box/sql/sqlInt.h
@@ -697,7 +697,8 @@ sql_bind_parameter_count(sql_stmt *stmt);
/**
* Return the name of a wildcard parameter. Return NULL if the index
- * is out of range or if the wildcard is unnamed.
+ * is out of range or if the wildcard is unnamed. Parameter's index
+ * is 0-based.
*/
const char *
sql_bind_parameter_name(sql_stmt *stmt, int i);
> --
> Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2019-12-13 13:55 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 21:27 [Tarantool-patches] [PATCH v2 00/16] sql: prepared statements Nikita Pettik
2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 01/16] sql: remove sql_prepare_v2() Nikita Pettik
2019-12-04 11:36 ` Konstantin Osipov
2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 02/16] sql: refactor sql_prepare() and sqlPrepare() Nikita Pettik
2019-12-03 22:51 ` Vladislav Shpilevoy
2019-12-04 11:36 ` Konstantin Osipov
2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 03/16] sql: move sql_prepare() declaration to box/execute.h Nikita Pettik
2019-12-04 11:37 ` Konstantin Osipov
2019-12-05 13:32 ` Nikita Pettik
2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 04/16] sql: rename sqlPrepare() to sql_compile() Nikita Pettik
2019-12-03 22:51 ` Vladislav Shpilevoy
2019-12-13 13:49 ` Nikita Pettik
2019-12-04 11:39 ` Konstantin Osipov
2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 05/16] sql: move sql_finalize() to execute.h Nikita Pettik
2019-12-03 22:51 ` Vladislav Shpilevoy
2019-12-04 11:39 ` Konstantin Osipov
2019-12-13 13:49 ` Nikita Pettik
2019-12-04 11:40 ` Konstantin Osipov
2019-12-05 13:37 ` Nikita Pettik
2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 06/16] port: increase padding of struct port Nikita Pettik
2019-12-04 11:42 ` Konstantin Osipov
2019-12-13 13:54 ` Nikita Pettik
2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 07/16] port: add dump format and request type to port_sql Nikita Pettik
2019-12-03 22:51 ` Vladislav Shpilevoy
2019-12-13 13:55 ` Nikita Pettik
2019-12-04 11:52 ` Konstantin Osipov
2019-12-13 13:53 ` Nikita Pettik
2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 08/16] sql: resurrect sql_bind_parameter_count() function Nikita Pettik
2019-12-03 22:51 ` Vladislav Shpilevoy
2019-12-04 11:54 ` Konstantin Osipov
2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 09/16] sql: resurrect sql_bind_parameter_name() Nikita Pettik
2019-12-04 11:55 ` Konstantin Osipov
2019-12-04 11:55 ` Konstantin Osipov
2019-12-13 13:55 ` Nikita Pettik [this message]
2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 10/16] sql: add sql_stmt_schema_version() Nikita Pettik
2019-12-04 11:57 ` Konstantin Osipov
2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 11/16] sql: introduce sql_stmt_sizeof() function Nikita Pettik
2019-12-03 22:51 ` Vladislav Shpilevoy
2019-12-13 13:56 ` Nikita Pettik
2019-12-04 11:59 ` Konstantin Osipov
2019-12-13 13:56 ` Nikita Pettik
2019-12-13 14:15 ` Konstantin Osipov
2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 12/16] box: increment schema_version on ddl operations Nikita Pettik
2019-12-04 12:03 ` Konstantin Osipov
2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 13/16] sql: introduce sql_stmt_query_str() method Nikita Pettik
2019-12-03 22:51 ` Vladislav Shpilevoy
2019-12-04 12:04 ` Konstantin Osipov
2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 14/16] sql: introduce cache for prepared statemets Nikita Pettik
2019-12-03 22:51 ` Vladislav Shpilevoy
2019-12-04 12:11 ` Konstantin Osipov
2019-12-17 14:43 ` Kirill Yukhin
2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 15/16] box: introduce prepared statements Nikita Pettik
2019-12-04 12:13 ` Konstantin Osipov
2019-12-06 23:18 ` Vladislav Shpilevoy
2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 16/16] netbox: " Nikita Pettik
2019-12-06 23:18 ` Vladislav Shpilevoy
2019-12-03 22:51 ` [Tarantool-patches] [PATCH v2 00/16] sql: " Vladislav Shpilevoy
2019-12-17 15:58 ` Georgy Kirichenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213135555.GA80915@tarantool.org \
--to=korablev@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 09/16] sql: resurrect sql_bind_parameter_name()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox