Re: [Tarantool-patches] [PATCH 2/2] fiber: destroy fiber.storage created by iproto

[Konstantin Osipov <kostja.osipov@gmail.com>]

* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/12/12 00:27]:
> - I moved cleanup to iproto.cc, and called it tx_fiber_cleanup().
>   By analogue with tx_fiber_init() which currently initializes the
>   fiber;
> 
> - I made cleanup triggers always clean them by themselves to remove
>   trigger_destroy() from fiber.c.
> 
> But it didn't help me to understand, why are you saying, that
> tx and session should not use these triggers. Tx, in case it was
> not removed from fiber before its cleanup, should be destroyed.
> Session uses that trigger to destroy local one-fiber sessions,
> which die together with the fiber getting recycled/killed. So
> what is a problem? That trigger perfectly fits all the needs.

OK, the function itself may be a match, but it doesn't make the
idea of using the same trigger object for everything right, don't
you think?

My point is that you do  not only move where the function is
invoked, but also where the trigger list object is stored.

Can you move it to Lua fiber object and iproto_msg object?
There could be no other entry points to the request, so my point
is that the trigger is part of request state, not fiber state.

Does it make any sense?

-- 
Konstantin Osipov, Moscow, Russia