From: Nikita Pettik <korablev@tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 0/2] Allow to convert big real values to integer
Date: Wed, 11 Dec 2019 17:23:17 +0300 [thread overview]
Message-ID: <20191211142317.GA41096@tarantool.org> (raw)
In-Reply-To: <cover.1575898091.git.imeevma@gmail.com>
On 09 Dec 16:34, imeevma@tarantool.org wrote:
> This patch-set fixes a bug that prevented the conversion of real
> values that are greater than INT64_MAX and less than UINT64_MAX to
> INTEGER and UNSIGNED.
LGTM. Pushed to master.
> https://github.com/tarantool/tarantool/issues/4526
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4526-big-float-to-int-conversation
>
> Mergen Imeev (2):
> sql: refactor sqlVdbeMemIntegerify() function
> sql: allow to convert big real values to integer
>
> src/box/sql/vdbe.c | 13 +++---
> src/box/sql/vdbeInt.h | 2 +-
> src/box/sql/vdbemem.c | 22 +++++-----
> test/sql-tap/numcast.test.lua | 83 +++++++++++++++++++++++++++++++++++++-
> test/sql/integer-overflow.result | 12 +++---
> test/sql/integer-overflow.test.lua | 10 ++---
> 6 files changed, 113 insertions(+), 29 deletions(-)
>
> --
> 2.7.4
>
prev parent reply other threads:[~2019-12-11 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 13:34 imeevma
2019-12-09 13:34 ` [Tarantool-patches] [PATCH v3 1/2] sql: refactor sqlVdbeMemIntegerify() function imeevma
2019-12-09 13:34 ` [Tarantool-patches] [PATCH v3 2/2] sql: allow to convert big real values to integer imeevma
2019-12-11 14:23 ` Nikita Pettik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211142317.GA41096@tarantool.org \
--to=korablev@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 0/2] Allow to convert big real values to integer' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox